Implement base structure for repository file artifacts #4018

vaibhavdaren · 2025-09-02T22:54:15Z

In this Pull request, I have added support for the Repository-File artifact type for the Almighty Install Plugin.
The classes add support for the file type.

implement the feature
Initial Review

For the next PR: #3995 (comment)

happz · 2025-09-03T11:02:59Z

@vaibhavdaren would it make sense to rebase this PR on top of the koji/brew one? #4011 That one seems to be adding the basic structure, and koji/brew "artifacts", I would expect the repository file to build upon that, adding new artifact type, sharing the directories with koji/brew providers, and so on.

vaibhavdaren · 2025-09-04T10:08:25Z

@vaibhavdaren would it make sense to rebase this PR on top of the koji/brew one? #4011 That one seems to be adding the basic structure, and koji/brew "artifacts", I would expect the repository file to build upon that, adding new artifact type, sharing the directories with koji/brew providers, and so on.

I have rebased on top of his branch. Changed functions to match signatures. Let me review the orginal CR and put my thoughts on that as well.

LecrisUT

I think for this PR the focus should be more on the design of the prepare plugin, namely:

Creating the PrepareRepoData and PrepareRepo skeleton, you can reference the prepare install plugin

tmt/tmt/steps/prepare/install.py

Lines 742 to 743 in 1d83cca

    
           @container 
        
           class PrepareInstallData(tmt.steps.prepare.PrepareStepData):

tmt/tmt/steps/prepare/install.py

Lines 799 to 800 in 1d83cca

    
           @tmt.steps.provides_method('install') 
        
           class PrepareInstall(tmt.steps.prepare.PreparePlugin[PrepareInstallData]):

(Naming of course flexible)

Hook into the providers to download the artifacts and do the actual repo creation
Misc adjustments like hooking into the schema and other stuff that would pop up

You could also focus this PR on the second point if you think the scope could be too big

tmt/steps/prepare/brand_new_allmighty_install/providers/__init__.py

AthreyVinay · 2025-09-04T20:52:37Z

FYI - there are still ongoing structural changes to the abstract class implementation :)

tmt/steps/prepare/feature/repo.py

psss

Looks like a good kick-off, thanks! I would just place the repository enablement implementation under a new method which would be used across all providers.

tmt/steps/prepare/artifact/providers/repository.py

psss

Thanks! Sounds good enough as the first version, let's start from here.

thrix · 2025-10-06T10:04:57Z

/packit retest-failed

tmt/steps/prepare/artifact/providers/repository_provider.py

This file provides classes for handling repository file artifacts in the tmt framework. It includes the `RepositoryFileInfo` class, which encapsulates metadata about a repository file. Fix #3995

**Note**: This separate PR enables a focused "work-shopping" session on the class structure. Isolating this major change from the much larger PR (#4018) provides clarity for discussion and refinement. This separation is a temporary measure, as the code will ultimately be a single commit within the main PR. * [x] Change the base structure skeleton

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

psss · 2025-10-08T05:25:45Z

The two failures are irrelevant, merging.

vaibhavdaren self-assigned this Sep 2, 2025

vaibhavdaren added the ci | skip Do not run any tests (useful for very early drafts). label Sep 2, 2025

vaibhavdaren marked this pull request as draft September 2, 2025 22:55

vaibhavdaren force-pushed the almight-repo-file branch from f59fc33 to fd29930 Compare September 3, 2025 02:04

vaibhavdaren added this to the 1.57 milestone Sep 3, 2025

vaibhavdaren added this to planning Sep 3, 2025

github-project-automation bot moved this to backlog in planning Sep 3, 2025

vaibhavdaren moved this from backlog to implement in planning Sep 3, 2025

vaibhavdaren force-pushed the almight-repo-file branch 2 times, most recently from 2fa47a5 to 9c7d609 Compare September 3, 2025 09:49

vaibhavdaren linked an issue Sep 3, 2025 that may be closed by this pull request

Prepare artifacts repository from repository file #3995

Open

vaibhavdaren force-pushed the almight-repo-file branch from 9c7d609 to a06d713 Compare September 3, 2025 10:58

vaibhavdaren requested a review from happz September 3, 2025 11:00

vaibhavdaren changed the base branch from main to avinay-brew-koji-build-helpers September 4, 2025 09:19

vaibhavdaren force-pushed the almight-repo-file branch 2 times, most recently from a1d5fb3 to c2f378d Compare September 4, 2025 09:55

vaibhavdaren closed this Sep 4, 2025

vaibhavdaren force-pushed the almight-repo-file branch from c2f378d to 6a8facb Compare September 4, 2025 09:59

github-project-automation bot moved this from implement to done in planning Sep 4, 2025

vaibhavdaren reopened this Sep 4, 2025

LecrisUT reviewed Sep 4, 2025

View reviewed changes

tmt/steps/prepare/brand_new_allmighty_install/providers/__init__.py Outdated Show resolved Hide resolved

vaibhavdaren mentioned this pull request Sep 4, 2025

Implement koji/brew classes for the artifact plugin #4011

Merged

2 tasks

AthreyVinay force-pushed the avinay-brew-koji-build-helpers branch from dc2cc84 to 6b79896 Compare September 5, 2025 15:38

vaibhavdaren force-pushed the almight-repo-file branch from 9e6407a to 279647f Compare September 5, 2025 20:22

vaibhavdaren moved this from done to review in planning Sep 8, 2025

vaibhavdaren marked this pull request as ready for review September 8, 2025 18:51

graphite-app bot reviewed Sep 8, 2025

View reviewed changes

tmt/steps/prepare/feature/repo.py Outdated Show resolved Hide resolved

psss requested changes Oct 2, 2025

View reviewed changes

tmt/steps/prepare/artifact/providers/repository.py Outdated Show resolved Hide resolved

LecrisUT approved these changes Oct 2, 2025

View reviewed changes

happz reviewed Oct 3, 2025

View reviewed changes

tmt/steps/prepare/artifact/providers/repository.py Outdated Show resolved Hide resolved

graphite-app bot reviewed Oct 3, 2025

View reviewed changes

tmt/steps/prepare/artifact/providers/repository.py Outdated Show resolved Hide resolved

vaibhavdaren requested a review from happz October 3, 2025 13:31

graphite-app bot reviewed Oct 3, 2025

View reviewed changes

tmt/steps/prepare/artifact/providers/repository.py Show resolved Hide resolved

tmt/steps/prepare/artifact/providers/repository.py Show resolved Hide resolved

tcornell-bus approved these changes Oct 3, 2025

View reviewed changes

vaibhavdaren requested a review from psss October 3, 2025 14:00

psss approved these changes Oct 6, 2025

View reviewed changes

thrix moved this from review to merge in planning Oct 6, 2025

AthreyVinay approved these changes Oct 7, 2025

View reviewed changes

tmt/steps/prepare/artifact/providers/repository_provider.py Outdated Show resolved Hide resolved

vaibhavdaren and others added 13 commits October 8, 2025 01:03

add repository file provider

2c866d0

This file provides classes for handling repository file artifacts in the tmt framework. It includes the `RepositoryFileInfo` class, which encapsulates metadata about a repository file. Fix #3995

fix doc strings

b84e3f5

add todo note

fe7b017

fix imports after code cleanup

0060187

rename file to the polished structure

63d674d

Suggestions from code review

d594bd8

resolve conflicts due to base class changes

49ad6d1

add suggestion from code review

4141f3c

polish class structure

124a9b9

rename download_artifacts to fetch_contents

13eed65

Update tmt/steps/prepare/artifact/providers/repository.py

8ec4769

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

make structure compatible with base class changes

0cedcf4

psss force-pushed the almight-repo-file branch from 2734c62 to 0cedcf4 Compare October 7, 2025 23:04

psss merged commit 3a64256 into main Oct 8, 2025
24 of 25 checks passed

psss deleted the almight-repo-file branch October 8, 2025 05:27

github-project-automation bot moved this from merge to done in planning Oct 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement base structure for repository file artifacts #4018

Implement base structure for repository file artifacts #4018

vaibhavdaren commented Sep 2, 2025 •

edited

Loading

Uh oh!

happz commented Sep 3, 2025

Uh oh!

vaibhavdaren commented Sep 4, 2025

Uh oh!

LecrisUT left a comment

Uh oh!

Uh oh!

AthreyVinay commented Sep 4, 2025

Uh oh!

Uh oh!

psss left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

psss left a comment

Uh oh!

thrix commented Oct 6, 2025

Uh oh!

Uh oh!

psss commented Oct 8, 2025

Uh oh!

Uh oh!

Uh oh!

	@container
	class PrepareInstallData(tmt.steps.prepare.PrepareStepData):

	@tmt.steps.provides_method('install')
	class PrepareInstall(tmt.steps.prepare.PreparePlugin[PrepareInstallData]):

Implement base structure for repository file artifacts #4018

Implement base structure for repository file artifacts #4018

Conversation

vaibhavdaren commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

happz commented Sep 3, 2025

Uh oh!

vaibhavdaren commented Sep 4, 2025

Uh oh!

LecrisUT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AthreyVinay commented Sep 4, 2025

Uh oh!

Uh oh!

psss left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

psss left a comment

Choose a reason for hiding this comment

Uh oh!

thrix commented Oct 6, 2025

Uh oh!

Uh oh!

psss commented Oct 8, 2025

Uh oh!

Uh oh!

Uh oh!

vaibhavdaren commented Sep 2, 2025 •

edited

Loading