Skip to content

Conversation

therazix
Copy link
Collaborator

@therazix therazix commented Oct 1, 2025

Add sync to the tmt-reboot-core script to flush buffers before reboot and prevent potential data loss.

Resolves #2840

Pull Request Checklist

  • implement the feature

@therazix therazix added this to planning Oct 1, 2025
@therazix therazix added the command | reboot Support for rebooting guests during `tmt run` and the `tmt-reboot` command label Oct 1, 2025
@github-project-automation github-project-automation bot moved this to backlog in planning Oct 1, 2025
@therazix therazix moved this from backlog to review in planning Oct 1, 2025
@happz happz added this to the 1.59 milestone Oct 1, 2025
@happz happz added the ci | full test Pull request is ready for the full test execution label Oct 2, 2025
@therazix therazix force-pushed the fvagner-reboot-sync branch from 575196b to 2a74367 Compare October 2, 2025 08:29
@therazix
Copy link
Collaborator Author

therazix commented Oct 2, 2025

Just to be clear - I wasn’t able to reproduce the issue mentioned in #2840, so I can’t say for sure whether this change fixes the journal issue, even though the issue states that adding a sync fixes it. If anyone knows how to reproduce it or how to test this, it would be appreciated.

@psss psss moved this from review to merge in planning Oct 2, 2025
@happz happz force-pushed the fvagner-reboot-sync branch 2 times, most recently from c23c7fa to e0fff30 Compare October 4, 2025 09:27
@happz happz force-pushed the fvagner-reboot-sync branch from e0fff30 to dae6be0 Compare October 6, 2025 11:59
@happz
Copy link
Collaborator

happz commented Oct 6, 2025

The remaining rpm build seems to be nothing but a stuck Packit notification, the build exists and the corresponding tests did finish successfully. Merging.

@happz happz merged commit 8e431b8 into main Oct 6, 2025
24 of 25 checks passed
@happz happz deleted the fvagner-reboot-sync branch October 6, 2025 14:31
@github-project-automation github-project-automation bot moved this from merge to done in planning Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci | full test Pull request is ready for the full test execution command | reboot Support for rebooting guests during `tmt run` and the `tmt-reboot` command
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

Calling to rstrnt-reboot with custom command corrupts journal
5 participants