Skip to content

Conversation

dashevchenko
Copy link
Contributor

@dashevchenko dashevchenko commented Sep 29, 2025

Pull Request description

  1. Fixed missing PUBACK when device connection failed.
  2. Fixed PUBACK duplication when the telemetry/attribute payload contains multiple devices.

PUBACK duplication before fix:
image

Single PUBACK after fix:
image (18)

General checklist

  • You have reviewed the guidelines document.
  • Labels that classify your pull request have been added.
  • The milestone is specified and corresponds to fix version.
  • Description references specific issue.
  • Description contains human-readable scope of changes.
  • Description contains brief notes about what needs to be added to the documentation.
  • No merge conflicts, commented blocks of code, code formatting issues.
  • Changes are backward compatible or upgrade script is provided.
  • Similar PR is opened for PE version to simplify merge. Crosslinks between PRs added. Required for internal contributors only.

Front-End feature checklist

  • Screenshots with affected component(s) are added. The best option is to provide 2 screens: before and after changes;
  • If you change the widget or other API, ensure it is backward-compatible or upgrade script is present.
  • Ensure new API is documented here

Back-End feature checklist

  • Added corresponding unit and/or integration test(s). Provide written explanation in the PR description if you have failed to add tests.
  • If new dependency was added: the dependency tree is checked for conflicts.
  • If new service was added: the service is marked with corresponding @TbCoreComponent, @TbRuleEngineComponent, @TbTransportComponent, etc.
  • If new REST API was added: the RestClient.java was updated, issue for Python REST client is created.
  • If new yml property was added: make sure a description is added (above or near the property).

@dashevchenko dashevchenko added Bug Major Transport Major improvement to transport (MQTT, CoAP, HTTP, etc) labels Sep 29, 2025
@dashevchenko dashevchenko added this to the 4.2.1 milestone Sep 29, 2025
@dashevchenko dashevchenko changed the title [MQTT API] MQTT API does not send ACK if message publishing fails [MQTT API] MQTT API PUBACK is not sent if publishing failed and is duplicated if message contains multiple devices Oct 2, 2025
@dashevchenko dashevchenko changed the title [MQTT API] MQTT API PUBACK is not sent if publishing failed and is duplicated if message contains multiple devices [GATEWAY API] PUBACK is not sent if publishing failed and is duplicated if message contains multiple devices Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Major Transport Major improvement to transport (MQTT, CoAP, HTTP, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant