Skip to content

fix_lwm2m: add to Front bootstrap Short Server id 0 or 65535 #14084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix_lwm2m: add to Front bootstrap Short Server id 0 or 65535 #14084

wants to merge 3 commits into from

Conversation

nickAS21
Copy link
Contributor

Pull Request description

https://thingsboard-portal.atlassian.net/browse/PROD-7008

Problem:

M2mDefaultBootstrapSessionManager - Endpoint: [94193A040301C3AC] [info: receives success response for:  BootstrapDiscoverRequest  / DiscoverResponse [code=CONTENT(205), content=[</>;lwm2m=1.1, </5/0>, </20/0>, </33911>;ver=2.0, </33911/0>, </4/0>, </11/0>, </11/1>, </10/0>, </33907>;ver=2.0, </33907/0>, </33908>;ver=2.0, </33908/0>, </33909>;ver=2.2, </33909/0>, </33910>;ver=2.0, </33910/0>, </33910/1>, </33905>;ver=2.0, </33905/0>, </33906>;ver=2.2, </33906/0>, </0/0>, </1>;ver=1.1, </3>;ver=1.1, </3/0>]]]
thingsboard-mytbpe-1         | 2025-09-16T16:19:43.857690790Z 2025-09-16 16:19:43,857 [CoapServer(main)#1] INFO  o.t.s.t.l.b.s.LwM2MBootstrapConfigStoreTaskProvider - Object after discover: [</>;lwm2m=1.1]
thingsboard-mytbpe-1         | 2025-09-16T16:19:43.857780593Z 2025-09-16 16:19:43,857 [CoapServer(main)#1] INFO  o.t.s.t.l.b.s.LwM2mDefaultBootstrapSessionManager - 
thingsboard-mytbpe-1         | 2025-09-16T16:19:44.926930819Z 2025-09-16 16:19:44,926 [CoapServer(main)#4] INFO  o.t.s.t.l.b.s.LwM2mDefaultBootstrapSessionManager - Endpoint: [94193A040301C3AC] [info: BootstrapReadRequest /1 receives error response BootstrapReadResponse [code=INTERNAL_SERVER_ERROR(500), errormessage=] ]
thingsboard-mytbpe-1         | 2025-09-16T16:19:44.927095023Z 2025-09-16 16:19:44,926 [CoapServer(main)#4] WARN  o.t.s.t.l.b.s.LwM2MBootstrapConfigStoreTaskProvider - Bootstrap ReadResponse return error BootstrapReadResponse [code=INTERNAL_SERVER_ERROR(500), errormessage=] : to continue bootstrap session without find Server Instance Id. DefaultBootstrapSession [id=kpi0L49IG1, endpoint=94193A040301C3AC, identity=IpPeer [peerAddress=/3.69.185.69:19929, identity=Identity [psk=94193A040301C3AC]], authorized=true, contentFormat=TLV(11542), applicationData={}, creationTime=1758039582562, request=org.eclipse.leshan.core.request.BootstrapRequest@8189b14, cancelled=false]
thingsboard-mytbpe-1         | 2025-09-16T16:19:44.927445733Z 2025-09-16 16:19:44,927 [CoapServer(main)#4] INFO  o.t.s.t.l.b.s.Lw

General checklist

  • You have reviewed the guidelines document.
  • Labels that classify your pull request have been added.
  • The milestone is specified and corresponds to fix version.
  • Description references specific issue.
  • Description contains human-readable scope of changes.
  • Description contains brief notes about what needs to be added to the documentation.
  • No merge conflicts, commented blocks of code, code formatting issues.
  • Changes are backward compatible or upgrade script is provided.
  • Similar PR is opened for PE version to simplify merge. Crosslinks between PRs added. Required for internal contributors only.

Front-End feature checklist

  • Screenshots with affected component(s) are added. The best option is to provide 2 screens: before and after changes;
  • If you change the widget or other API, ensure it is backward-compatible or upgrade script is present.
  • Ensure new API is documented here

Back-End feature checklist

  • Added corresponding unit and/or integration test(s). Provide written explanation in the PR description if you have failed to add tests.
  • If new dependency was added: the dependency tree is checked for conflicts.
  • If new service was added: the service is marked with corresponding @TbCoreComponent, @TbRuleEngineComponent, @TbTransportComponent, etc.
  • If new REST API was added: the RestClient.java was updated, issue for Python REST client is created.
  • If new yml property was added: make sure a description is added (above or near the property).

vvlladd28
vvlladd28 reviewed Sep 30, 2025
View reviewed changes
...c/app/modules/home/components/profile/device/lwm2m/lwm2m-device-config-server.component.html Outdated
Comment on lines 61 to 62
<input *ngIf="!isBootstrap" matInput type="number" [min]="shortServerIdMin" [max]="shortServerIdMax" formControlName="shortServerId" required>
<input *ngIf="isBootstrap" matInput type="number" formControlName="shortServerId" required>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attributes min and max are automatically set when adding validators min and max in the form control

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ок

...src/app/modules/home/components/profile/device/lwm2m/lwm2m-device-config-server.component.ts
Comment on lines +79 to +80
readonly shortServerIdBsMin = 0;
readonly shortServerIdBsMax = 65535;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this variables unused

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ок

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvlladd28 vvlladd28 vvlladd28 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickAS21 @vvlladd28