Skip to content

Enable builds on Fedora using Packit #3479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable builds on Fedora using Packit #3479

wants to merge 1 commit into from

Conversation

bkmgit
Copy link
Collaborator

@bkmgit bkmgit commented May 22, 2025

Closes #3371

To get it to work, someone with commit access will need to agree to make a Fedora account at:
https://accounts.fedoraproject.org/

and agree to Fedora Code of Conduct, then follow the steps at:

http://packit.dev/docs/guide#1-set-up-packit-integration

@bkmgit bkmgit requested a review from hermet as a code owner May 22, 2025 14:05
@hermet hermet added the infrastructure Dev infrastructure label May 22, 2025
@hermet hermet force-pushed the main branch 5 times, most recently from 9b6c8bc to a6ffb7a Compare June 23, 2025 07:12
@hermet hermet force-pushed the main branch 5 times, most recently from 7ceb794 to 43923a5 Compare June 25, 2025 15:59
@hermet hermet force-pushed the main branch 4 times, most recently from 9ddde24 to dac61de Compare August 5, 2025 04:06
@hermet hermet force-pushed the main branch 9 times, most recently from 30c82d7 to 0c3e8ff Compare September 3, 2025 17:59
@bkmgit
Copy link
Collaborator Author

bkmgit commented Sep 5, 2025

@hermet Is anything else needed from me for this?

@hermet hermet requested a review from Copilot September 8, 2025 14:09
@github-actions github-actions bot removed the infrastructure Dev infrastructure label Sep 8, 2025
Copilot
Copilot AI reviewed Sep 8, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables Fedora package builds for ThorVG using Packit, a tool that automates package building and testing for Fedora. The changes add the necessary RPM spec file for building ThorVG packages and configure Packit to automatically build packages on pull requests.

  • Adds a comprehensive RPM spec file for ThorVG with proper dependencies and build configuration
  • Configures Packit to build packages for multiple Fedora architectures on pull request triggers

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
buildtools/thorvg.spec Complete RPM spec file defining package metadata, dependencies, build steps, and file listings for main, devel, and doc packages
.packit.yml Packit configuration file specifying build targets and notification settings for automated Fedora builds

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

buildtools/thorvg.spec
- Animations: Lottie

%package devel
Summary: Development headres and libraries
Copy link
Preview

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in 'headres' which should be 'headers'.

Suggested change
Summary: Development headres and libraries
Summary: Development headers and libraries

Copilot uses AI. Check for mistakes.

@hermet
Copy link
Member

hermet commented Sep 8, 2025 •
edited
Loading

@hermet Is anything else needed from me for this?

@bkmgit hi, thanks for contribution. Still there are 2 thing we might need a confident to apply this.

  1. Adding a Fedora-specific configuration introduces a dependency on a particular Linux distribution, which could compromise ThorVG's platform neutrality. Therefore, it might be more appropriate to place such scripts under a dedicated directory like thorvg/packaging/fedora/, and include any necessary CI scripts there. Maybe you can update this.

  2. This is the current concern for me. From ThorVG’s perspective, it’s unclear whether this script is truly valid or maintainable. We’re not sure if it might break due to updates elsewhere. In other words, we need to carefully consider the long-term maintenance responsibilities involved. (How to solve this?)

@hermet hermet added the infrastructure Dev infrastructure label Sep 8, 2025
@hermet hermet force-pushed the main branch 2 times, most recently from 7b0fe6f to 811aac3 Compare September 22, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@hermet hermet Awaiting requested review from hermet hermet is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@bkmgit bkmgit

Labels
infrastructure Dev infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infra: enhanced the github test process by integrating Fedora builds.
2 participants
@bkmgit @hermet