lottie: fix offset with miter join #3526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One point was skipped during the creation of the offset corner. The error was not visible because the point lies on the line, but it will become apparent if further modifiers are applied to the object (not supported now).
There was a problem hiding this comment.
Pull Request Overview
Fixes a skipped corner point in the offset path when using miter joins, ensuring subsequent modifiers render correctly.
- Refactored the miter-join branch to explicitly push an intersection point and then always push the next segment’s start.
- Broke out the inline conditional into a clear
ifblock followed by separate path commands.
Comments suppressed due to low confidence (3)
src/loaders/lottie/tvgLottieModifier.cpp:123
- Consider adding a guard to ensure
length(norm + nextNorm)is not near zero before normalizing, to avoid potential division by zero.
auto miterDirection = (norm + nextNorm) / length(norm + nextNorm);
src/loaders/lottie/tvgLottieModifier.cpp:128
- [nitpick] Add a brief comment explaining why two consecutive
LineTocommands are issued (first to the miter intersection, then tonextLine.pt1) to improve readability.
out.cmds.push(PathCommand::LineTo);
src/loaders/lottie/tvgLottieModifier.cpp:124
- Consider adding unit tests for both miter and bevel join scenarios around the miter limit to verify that the intersection and
nextLine.pt1points are correctly included in the generated path.
if (1.0f <= miterLimit * fabsf(miterDirection.x * norm.x + miterDirection.y * norm.y)) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One point was skipped during the creation of the offset corner. The error was not visible because the point lies on the line, but it will become apparent if further modifiers are applied to the object (not supported now).
samples not supported now (#3378 used to render the sample):
before this change:
after this change:
AE:
sample:
pucker_rect_op_miter4.json