webgl: fix target resolving invalid operation #3868
+24
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a WebGL-specific issue where attempting to blit from a multisampled framebuffer results in an invalid operation error when bounds or format don't match between source and destination framebuffers. The fix adds a pre-resolve step for multisampled buffers specifically for WebGL/Emscripten environments.
- Adds source framebuffer target setting capability to GlSceneBlendTask
- Implements WebGL-specific workaround with pre-resolve step before final blit operation
- Maintains existing behavior for non-WebGL platforms
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tvgGlRenderer.cpp | Sets the source target for blend tasks to enable WebGL workaround |
| tvgGlRenderTask.h | Adds source framebuffer member and setter method to GlSceneBlendTask |
| tvgGlRenderTask.cpp | Implements WebGL-specific two-step blit operation with pre-resolve |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fccaaf1 to
9c718fc
Compare
hermet
reviewed
Oct 3, 2025
0d83195 to
d48278d
Compare
WebGL attempt to blit from a multisampled framebuffer and the bounds or format of the color buffer don't match with the draw framebuffer. In this case we must to pre-resolve multisampled buffer to the existing render target buffer This workaround applies only in case of webgl (emscripten) #3837
d48278d to
1c8f71c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebGL attempt to blit from a multisampled framebuffer and the bounds or format of the color buffer don't match with the draw framebuffer.
In this case we must to pre-resolve multisampled buffer to the existing render target buffer
This workaround applies only in case of webgl (emscripten)