appendChild not aware of void elements #311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this conceptually, but I'm not sure whether it is the correct thing to do. Current versions of all the major browsers allow you to add child nodes to a |
|
You are correct, elements can be appended to void elements, however they are not rendered. If changing existing functionality is undesirable, maybe just expose a method for checking whether an element can be appended as a child, that would satisfy my requirements also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, calling insertNodeAtPosition where n is a void element (e.g.,
<br>) causes the element to be appended as a child element, which results (potentially) in invalid nested elements.I have added an array containing all the void elements as per http://www.w3.org/TR/html-markup/syntax.html#void-elements, and a function canAppendChild(element) to avoid this issue.