Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan package.json last #644

Merged
merged 5 commits into from
Dec 20, 2020
Merged

Scan package.json last #644

merged 5 commits into from
Dec 20, 2020

Conversation

shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented Dec 20, 2020

Pull Request

Problem

Including package.json in auto blocks the use of the more explicit version control files further up the folder hierarchy, particularly in mono-repo layout. The package.json is not likely to be as good a source of a specific version to install as the other version control files.

Related: #636 #639 #640 #637

Solution

  • auto scans for package.json only after looking for other (better) files up hierarchy.
  • add engine
  • rework tests to remove misuse of BATS run and make tests more maintainable

ChangeLog

Changed

Added

  • engine label to look for engines.node in package.json (as used byauto)

@shadowspawn shadowspawn changed the base branch from master to develop December 20, 2020 00:08
@shadowspawn shadowspawn marked this pull request as ready for review December 20, 2020 03:16
@shadowspawn shadowspawn merged commit 228dc1c into develop Dec 20, 2020
@shadowspawn shadowspawn added pending release Merged into a branch for a future release, but not released yet and removed pending release Merged into a branch for a future release, but not released yet labels Dec 20, 2020
@shadowspawn shadowspawn deleted the feature/package-last branch December 20, 2020 04:26
@shadowspawn
Copy link
Collaborator Author

shadowspawn commented Dec 20, 2020

Released in v7.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant