If jq is installed, use it to get values from package.json
#810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`jq` is a popular choice for being installed, especially on CI machines, and using it is much faster than running node.
shadowspawn
reviewed
Aug 12, 2024
| if command -v jq &> /dev/null; then | ||
| command -v jq && jq --version | ||
| else | ||
| echo "jq not found, can be used to get package.json values faster than node" |
There was a problem hiding this comment.
Suggested change
| echo "jq not found, can be used to get package.json values faster than node" | |
| echo "jq not found. Optional install used for reading engine version from package.json." |
There was a problem hiding this comment.
Yeah, I don't mind the phrasing -- I forgot to say that you should make it whatever fits...
shadowspawn
approved these changes
Aug 12, 2024
|
Thanks for this great package! Please label 10.0.0 as |
|
Labelled as latest now on GitHub releases page. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
jqis a popular choice for being installed, especially on CI machines, and using it is much faster than running node.Problem
Using
nodecan be problematic if it's not installed yet, and it also has a much higher overhead (= time) to start. Doesn't matter for an automated CI case, but in interactive use the potential doubling of runningnodeis noticeable.Solution
Use
jqif it's installed. This is very straightforward use ofjq, so prefer that overnodeif it is installed.ChangeLog
jqto read values frompackage.jsonif it is installed.Closes #807.