Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fs adds copy & link #100

Merged
merged 14 commits into from
Nov 19, 2024
Merged

feat: Fs adds copy & link #100

merged 14 commits into from
Nov 19, 2024

Conversation

KKould
Copy link
Contributor

@KKould KKould commented Nov 11, 2024 •
edited
Loading

ref: #99

  • local filesystem can implement link and copy
  • s3 can implement copy
  • Implement file copy between different filesystems e.g. src: TokioFs & dst: AmazonS3

@KKould KKould requested a review from ethe November 11, 2024 09:39
@KKould KKould self-assigned this Nov 11, 2024
@KKould KKould added the enhancement New feature or request label Nov 11, 2024
@KKould KKould force-pushed the feat/fs_copy_and_link branch 5 times, most recently from 55a9d5e to 70e8d1a Compare November 12, 2024 09:51
@KKould KKould marked this pull request as ready for review November 12, 2024 09:55
@KKould KKould changed the title feat: Fs adds copy & link, TokioFs & TokioUringFs & Monoio have been implemented feat: Fs adds copy & link Nov 12, 2024
ethe
ethe requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@ethe ethe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we fix CI first?

ethe
ethe reviewed Nov 14, 2024
View reviewed changes
@KKould KKould force-pushed the feat/fs_copy_and_link branch from 8b9a8fd to b9ee792 Compare November 15, 2024 03:47
@KKould KKould requested a review from ethe November 15, 2024 04:03
@KKould
Copy link
Contributor Author

KKould commented Nov 15, 2024

Please wait for the pr: tonbo-io/tonbo#219 approval before merging

@KKould KKould force-pushed the feat/fs_copy_and_link branch 2 times, most recently from 529ba38 to 90d847e Compare November 15, 2024 11:29
@KKould KKould force-pushed the feat/fs_copy_and_link branch from 90d847e to a86969d Compare November 15, 2024 11:43
@ethe ethe force-pushed the feat/fs_copy_and_link branch from 0758619 to aed3c0e Compare November 19, 2024 08:01
@ethe ethe force-pushed the feat/fs_copy_and_link branch from aed3c0e to db7c1dc Compare November 19, 2024 08:07
@ethe ethe merged commit 482b392 into main Nov 19, 2024
6 checks passed
@ethe ethe deleted the feat/fs_copy_and_link branch November 19, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethe ethe ethe approved these changes

Assignees

@KKould KKould

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KKould @ethe