Skip to content

stat: fix %N symlink to be single quote instead of double quote #8791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

stat: fix %N symlink to be single quote instead of double quote #8791

wants to merge 6 commits into from
+27 −2

Conversation

dekuu5
Copy link
Contributor

@dekuu5 dekuu5 commented Oct 2, 2025

fix #8789

@dekuu5 dekuu5 marked this pull request as draft October 2, 2025 19:54
@dekuu5
Copy link
Contributor Author

dekuu5 commented Oct 2, 2025

i think i need to fix this failing test first

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2025

GNU testsuite comparison:

GNU test failed: tests/stat/stat-fmt. tests/stat/stat-fmt is passing on 'main'. Maybe you have to rebase?

@dekuu5 dekuu5 marked this pull request as ready for review October 4, 2025 16:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 4, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8791 will improve performances by 3.28%

Comparing dekuu5:stat/fix-symlink-behavior (f4fadd4) with main (1428bd7)

Summary

⚡ 1 improvement
✅ 78 untouched
⏩ 73 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ du_human_balanced_tree[(5, 4, 10)] 10.5 ms 10.1 ms +3.28%

Footnotes

  1. 73 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@sylvestre
Copy link
Contributor

Could you please add a test to make sure we don't regress?

@dekuu5
Copy link
Contributor Author

dekuu5 commented Oct 5, 2025

Sure, I will get started on it

sylvestre
sylvestre reviewed Oct 6, 2025
View reviewed changes
@dekuu5 dekuu5 requested a review from sylvestre October 6, 2025 18:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@sylvestre
Copy link
Contributor

I would like an integration test in tests/by-util/test_stat.rs

@dekuu5
Copy link
Contributor Author

dekuu5 commented Oct 8, 2025

Alright sure I will add it

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre Awaiting requested review from sylvestre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stat: change in behavior from gnu-coreutils stat -c %N symlinks reported with double quotes instead of single
2 participants
@dekuu5 @sylvestre