Proper parsing of newer aws sdks #548
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend test cases to support aws v2 sdk for some languages
fix test case
Add support for the following aws sdk identification: aws-sdk-go-v2 aws-sdk-js aws-sdk-ruby3
|
Tests successfully executed locally also. |
Fix test cases patch version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've being using this library successfuly in a data processing pipeline. Recently, I've noticied some useragent strings are not being processed correctly.
For example:
aws-sdk-go-v2/1.18 os/linux lang/go/1.20 md/GOOS/linux md/GOARCH/amd64 api/sts/1.18
aws-sdk-js/3.294 os/linux/5.15 lang/js md/nodejs/16.19 api/dynamodb/3.294
aws-sdk-ruby3/3.170 ruby/3.0 x86_64-linux-musl aws-sdk-core/3.170
For such strings, ua-parser does not identifies the user_agent family or the major/minor versions.