Skip to content

Introduce a bark-to-zap compatibility wrapper #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2017
Merged

Introduce a bark-to-zap compatibility wrapper #14

merged 3 commits into from
Sep 18, 2017

Conversation

akshayjshah
Copy link
Contributor

This PR renames the zap-to-bark wrapper, then introduces a bark-to-zap wrapper.

Akshay Shah added 2 commits September 15, 2017 18:47
Rename zbark.New to zbark.Barkify
314e4ff 
Since we need wrappers in both the bark-to-zap and zap-to-bark
direction, rename to make some conceptual space.
Introduce bark-to-zap compatibility
2fa2ec2 
Add a `Zapify` function that converts a bark logger to a zap logger.
@akshayjshah akshayjshah requested a review from abhinav September 16, 2017 02:19
@akshayjshah akshayjshah merged commit dfa0983 into master Sep 18, 2017
@akshayjshah akshayjshah deleted the ajs-zap branch September 18, 2017 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@abhinav abhinav abhinav approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akshayjshah @abhinav