Skip to content

Remove GeoMultiPolygon since it is not used #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove GeoMultiPolygon since it is not used #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions dev-docs/RFCs/v4.0.0/names_for_concepts_types_functions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,13 +276,12 @@ discussion requiring benchmarking, so we will defer that to a

- rename `GeoBoundary` to `CellBoundary` to indicate it is space-limited to describing the geometry of cells

| Current name | Proposed name | Notes |
|-------------------|-------------------|---------------------------------|
| `GeoCoord` | `LatLng` | |
| `GeoBoundary` | `CellBoundary` | <= 10 stack-allocated `LatLng`s |
| `Geofence` | `GeoLoop` | heap-allocated `LatLng`s |
| `GeoPolygon` | `GeoPolygon` | |
| `GeoMultiPolygon` | `GeoMultiPolygon` | currently not used |
| Current name | Proposed name | Notes |
|---------------|----------------|---------------------------------|
| `GeoCoord` | `LatLng` | |
| `GeoBoundary` | `CellBoundary` | <= 10 stack-allocated `LatLng`s |
| `Geofence` | `GeoLoop` | heap-allocated `LatLng`s |
| `GeoPolygon` | `GeoPolygon` | |


### Functions
Expand All @@ -295,4 +294,4 @@ discussion requiring benchmarking, so we will defer that to a
| *DNE* | `boundaryToLoop` | |
| `getH3UnidirectionalEdgeBoundary` | `directedEdgeToBoundary` | returns `CellBoundary` |
| `h3SetToLinkedGeo` | `cellsToLinkedMultiPolygon` | returns `LinkedGeoPolygon` |
| `h3SetToToMultiPolygon` | `cellsToMultiPolygon` | bindings only |
| `h3SetToToMultiPolygon` | `cellsToMultiPolygon` | bindings only |
8 changes: 0 additions & 8 deletions src/h3lib/include/h3api.h.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,14 +149,6 @@ typedef struct {
GeoLoop *holes; ///< interior boundaries (holes) in the polygon
} GeoPolygon;

/** @struct GeoMultiPolygon
* @brief Simplified core of GeoJSON MultiPolygon coordinates definition
*/
typedef struct {
int numPolygons;
GeoPolygon *polygons;
} GeoMultiPolygon;

/** @struct LinkedLatLng
* @brief A coordinate node in a linked geo structure, part of a linked list
*/
Expand Down
15 changes: 7 additions & 8 deletions website/docs/library/migration-3.x/functions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,13 +149,12 @@ the passed-in cell.

- rename `GeoBoundary` to `CellBoundary` to indicate it is space-limited to describing the geometry of cells

| 3.x name | 4.0.0 name | Notes |
|-------------------|-------------------|-----------------------------------|
| `GeoBoundary` | `CellBoundary` | <= 10 stack-allocated `LatLng`s |
| `GeoCoord` | `LatLng` | |
| `Geofence` | `GeoLoop` | heap-allocated `LatLng`s |
| `GeoPolygon` | `GeoPolygon` | |
| `GeoMultiPolygon` | `GeoMultiPolygon` | currently not used |
| 3.x name | 4.0.0 name | Notes |
|---------------|----------------|---------------------------------|
| `GeoBoundary` | `CellBoundary` | <= 10 stack-allocated `LatLng`s |
| `GeoCoord` | `LatLng` | |
| `Geofence` | `GeoLoop` | heap-allocated `LatLng`s |
| `GeoPolygon` | `GeoPolygon` | |


### Functions
Expand All @@ -168,4 +167,4 @@ the passed-in cell.
| *DNE* | `boundaryToLoop` | |
| `getH3UnidirectionalEdgeBoundary` | `directedEdgeToBoundary` | returns `CellBoundary` |
| `h3SetToLinkedGeo` | `cellsToLinkedMultiPolygon` | returns `LinkedGeoPolygon` |
| `h3SetToToMultiPolygon` | `cellsToMultiPolygon` | bindings only |
| `h3SetToToMultiPolygon` | `cellsToMultiPolygon` | bindings only |