Skip to content

Move defer outside of if statement #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Move defer outside of if statement #24

wants to merge 1 commit into from

Conversation

keith
Copy link

@keith keith commented Dec 7, 2018

Previously this defer would fire at the end of the if statement when it
likely should have been firing at the end of the dispatch_async.

@keith
Move defer outside of if statement
bce0105 
Previously this defer would fire at the end of the if statement when it
likely should have been firing at the end of the dispatch_async.
@CLAassistant
Copy link

CLAassistant commented Dec 7, 2018 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@keith keith closed this Dec 7, 2018
@neakor
Copy link
Contributor

neakor commented Dec 12, 2018

Thanks for this. We had merged this as you may have noticed #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keith @CLAassistant @neakor