optlib: allow users to set fields and check extras defined in a foreign language #3960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3960 +/- ##
==========================================
+ Coverage 85.50% 85.52% +0.01%
==========================================
Files 237 237
Lines 57042 57143 +101
==========================================
+ Hits 48776 48869 +93
- Misses 8266 8274 +8 ☔ View full report in Codecov by Sentry. |
e14c4e6
to
cbdc8c8
Compare
|
The ways to support boolean fields are not consistent in various aspects. |
d9408cb
to
ae46592
Compare
ae46592
to
eba8b2e
Compare
|
I added test cases. The top half of this pull request can be merged. I will make a pull request. |
…for newly defined field Signed-off-by: Masatake YAMATO <yamato@redhat.com>
--_list-fielddef-flags option is added, too. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
…field setters This is a preparation. A test case for raising the error introduced in this commit will be added when we have real field accessors. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
The operators (setter and/or getter) for each field. The name of operatos has following form: setter => :<LANG>.<FIELD> getter => <LANG>.<FIELD>: NOTE: The operators for a field are defined only if the field has C level getters and setters, getValueObject and setValueObject in fieldDefinition. This commit doesn't provide a getter and a setter. The test cases and the real accessor will be implemented later. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
…ned in an optlib parser Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
eba8b2e
to
c50fcca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, this pull request allows you to fill out a field for a foreign tag from optscript.