-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a basic cookie store #969
Conversation
Some progress made already: see #968 (comment) |
75af7ca
to
915639d
Compare
gotta love some good rebase ✨ literally best git command |
47c1425
to
04f7299
Compare
@helloanoop pls review; I hope the code works; Tell me how to refactor & add screenshots/docu to meet the projects goals; thanks |
Hi @Tanja-4732 Appreciate all the work, but won't be able to get this in. Below are the issues
Since this a key feature and many folks are blocked, I went ahead and have implemented the cookie support e1a96e0 However, there is still a lot more work needed on cookie support, specially around adding, editing and deleting cookies. |
Thanks for your efforts in
Do you think these additional changes should be made in a new PR? |
@Tanja-4732 Yes, there is work left on adding, editing and deleting cookies. Let's pick one at a time. When you find some time, it'd be great of you could work on support for deleting cookies. |
@Tanja-4732 Closing this PR. In case you are working on support for deleting cookies, please sync your fork's main with |
Will do soon enough 👍 ✨ |
@helloanoop is this still relevant? I could port my existing UI-work to your cookie implementation. Should I? |
Description
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.
My checklist
closes #968