Replace browser history instead of pushing to it #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the browser history would be severely spammed whenever the settings were rapidly changed (e.g. FOV change) This commit changes it to use history.replaceState instead Compatible with IE10+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the browser history would be severely spammed whenever the settings were rapidly changed (e.g. FOV change).
This commit changes it to use
history.replaceStateinstead, which replaces the current entry in history instead of creating a new entry. A fallback has been added just in casehistory.replaceStatefails, although it should be implemented all the way back to IE10.