-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UPDATE] error friendly messages for null and undefined values #1041
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, can you add a test?
https://github.com/wxt-dev/wxt/blob/main/packages/i18n/src/__tests__/build.test.ts
cd packages/18n
pnpm test
Will merge next time I'm on github once the checks pass! |
@wxt-dev/auto-icons
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-svelte
@wxt-dev/module-solid
@wxt-dev/module-vue
wxt
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1041 +/- ##
==========================================
+ Coverage 81.79% 81.98% +0.19%
==========================================
Files 127 127
Lines 6635 6635
Branches 1102 1103 +1
==========================================
+ Hits 5427 5440 +13
+ Misses 1194 1181 -13
Partials 14 14 ☔ View full report in Codecov by Sentry. |
… message files (wxt-dev#1041) Co-authored-by: windmillcode0 <michaelodumosu57@gmail.com>
You may run your i18n files through ai and ai may not be perfect it may introduce undefined or null values this changes gives more human friendly output for the developer to more easily fix the problem