[UPDATE] error friendly messages for null and undefined values #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aklinker1
requested changes
Oct 4, 2024
There was a problem hiding this comment.
Thanks for the PR, can you add a test?
https://github.com/wxt-dev/wxt/blob/main/packages/i18n/src/__tests__/build.test.ts
cd packages/18n
pnpm test
aklinker1
approved these changes
Oct 4, 2024
|
Will merge next time I'm on github once the checks pass! |
@wxt-dev/auto-icons
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-svelte
@wxt-dev/module-solid
@wxt-dev/module-vue
wxt
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1041 +/- ##
==========================================
+ Coverage 81.79% 81.98% +0.19%
==========================================
Files 127 127
Lines 6635 6635
Branches 1102 1103 +1
==========================================
+ Hits 5427 5440 +13
+ Misses 1194 1181 -13
Partials 14 14 ☔ View full report in Codecov by Sentry. |
Timeraa
pushed a commit
to Timeraa/wxt
that referenced
this pull request
Oct 4, 2024
… message files (wxt-dev#1041) Co-authored-by: windmillcode0 <michaelodumosu57@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You may run your i18n files through ai and ai may not be perfect it may introduce undefined or null values this changes gives more human friendly output for the developer to more easily fix the problem