Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify options ZoomFactor and IsZoomControlEnabled to windows only… #3644

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

levinit
Copy link
Contributor

@levinit levinit commented Jul 29, 2024

Description

IsZoomControlEnabled and ZoomFactor are windows only options.

Fixes #3643 #3191

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using wails doctor.

  • Windows
  • macOS
  • Linux

Test Configuration

Please paste the output of wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Summary by CodeRabbit

  • Documentation
    • Reorganized documentation for ZoomFactor and IsZoomControlEnabled options across multiple language references to enhance clarity and accessibility.
    • Improved logical flow by repositioning zoom-related information to better align with user needs.
    • Maintained existing definitions and functionalities for all options.
    • Updated changelog to clarify that ZoomFactor and IsZoomControlEnabled are now Windows-only features, affecting users on other operating systems.

Copy link
Contributor

coderabbitai bot commented Jul 29, 2024

## Walkthrough

The documentation has been reorganized to enhance clarity and accessibility for the `ZoomFactor` and `IsZoomControlEnabled` options across various language files. These sections have been strategically relocated to improve user comprehension while maintaining their original functionality.

## Changes

| Files                                                                 | Change Summary                                                                                                                                                        |
|-----------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `website/docs/reference/options.mdx`                                 | Sections for `ZoomFactor` and `IsZoomControlEnabled` moved to a more prominent position to improve clarity and accessibility.                                      |
| `website/i18n/ar/docusaurus-plugin-content-docs/current/reference/options.mdx`  | Sections for `ZoomFactor` and `IsZoomControlEnabled` relocated for improved document flow.                                                                           |
| `website/i18n/fr/docusaurus-plugin-content-docs/current/reference/options.mdx`  | Sections for `ZoomFactor` and `IsZoomControlEnabled` reorganized within the document, maintaining original content.                                                |
| `website/i18n/ja/docusaurus-plugin-content-docs/current/reference/options.mdx`  | Sections moved to a later part of the document to enhance readability and logical structure.                                                                       |
| `website/i18n/ko/docusaurus-plugin-content-docs/current/reference/options.mdx`  | Sections for `ZoomFactor` and `IsZoomControlEnabled` removed from one location and reintroduced to improve organization.                                          |
| `website/i18n/pt/docusaurus-plugin-content-docs/current/reference/options.mdx`  | Sections for `ZoomFactor` and `IsZoomControlEnabled` consolidated under a dedicated zoom functionality section for clarity.                                        |
| `website/i18n/ru/docusaurus-plugin-content-docs/current/reference/options.mdx`  | Sections for `ZoomFactor` and `IsZoomControlEnabled` reorganized without content changes, improving accessibility.                                                  |
| `website/i18n/tr/docusaurus-plugin-content-docs/current/reference/options.mdx`  | Sections for `ZoomFactor` and `IsZoomControlEnabled` restructured within the document to enhance clarity.                                                          |
| `website/i18n/vi/docusaurus-plugin-content-docs/current/reference/options.mdx`  | Sections relocated to improve logical flow, retaining their definitions and functionalities.                                                                         |
| `website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/reference/options.mdx` | Sections for `ZoomFactor` and `IsZoomControlEnabled` reintroduced in a different location to enhance clarity.                                                       |

## Assessment against linked issues

| Objective                                                   | Addressed | Explanation                                               |
|------------------------------------------------------------|-----------|----------------------------------------------------------|
| `IsZoomControlEnabled` and `ZoomFactor` are windows only options (3643) ||                                                          |

> 🐰 Hopping through the code,  
> With changes bright and bold,  
> Zoom settings now refined,  
> Clear paths for all to find.  
> No features lost in flight,  
> Just clarity and light! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@levinit levinit changed the title Modify options ZoomFactor and IsZoomControlEnabled to to windows only… Modify options ZoomFactor and IsZoomControlEnabled to windows only… Jul 29, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (3)
website/i18n/ja/docusaurus-plugin-content-docs/current/reference/options.mdx (1)

543-547: Ensure clarity and address redundancy in IsZoomControlEnabled documentation.

The reintroduced documentation for IsZoomControlEnabled appears correct. However, consider rephrasing to avoid redundancy:

- このオプションを有効にすると、拡大率をユーザによって変更することができます。 拡大率の変更がユーザに許可されていない間は、オプションで拡大率を設定することができますのでご注意ください (例:  キオスクアプリケーションなど)。
+ このオプションを有効にすると、拡大率をユーザが変更できます。 拡大率の変更がユーザに許可されていない場合でも、オプションで拡大率を設定できます (例:  キオスクアプリケーションなど)。
Tools
LanguageTool

[uncategorized] ~547-~547: 「ことができる」という表現は冗長な可能性があります。
Context: ...: bool このオプションを有効にすると、拡大率をユーザによって変更することができます。 拡大率の変更がユーザに許可されていない間は、オプションで拡大率を設定する...

(DOUSI_KOTOGADEKIRU)


[uncategorized] ~547-~547: 「ことができる」という表現は冗長な可能性があります。
Context: ...きます。 拡大率の変更がユーザに許可されていない間は、オプションで拡大率を設定することができますのでご注意ください (例: キオスクアプリケーションなど)。 ####...

(DOUSI_KOTOGADEKIRU)

website/i18n/fr/docusaurus-plugin-content-docs/current/reference/options.mdx (2)

537-542: Ensure clarity and correct whitespace in ZoomFactor documentation.

The reintroduced documentation for ZoomFactor appears correct. However, correct the whitespace issue:

- Nom: ZoomFactor<br/> Type: `float64`
+ Nom: ZoomFactor<br/>Type: `float64`
Tools
LanguageTool

[uncategorized] ~538-~538: Les deux-points sont précédés d’une espace insécable.
Context: ... | #### ZoomFactor Nom: ZoomFactor
Type: float64 Ceci d...

(FRENCH_WHITESPACE)


[uncategorized] ~539-~539: Les deux-points sont précédés d’une espace insécable.
Context: ... #### ZoomFactor Nom: ZoomFactor
Type: float64 Ceci définit le facteur de z...

(FRENCH_WHITESPACE)


543-547: Ensure clarity and address redundancy in IsZoomControlEnabled documentation.

The reintroduced documentation for IsZoomControlEnabled appears correct. However, consider rephrasing to avoid redundancy:

- Cela permet de modifier le facteur de zoom par l'utilisateur. Veuillez noter que le facteur de zoom peut être défini dans les options tandis que ne permet pas à l'utilisateur de le modifier à l'exécution (f.e. pour une application vitrine ou similaire).
+ Cela permet de modifier le facteur de zoom par l'utilisateur. Veuillez noter que le facteur de zoom peut être défini dans les options sans permettre à l'utilisateur de le modifier à l'exécution (par exemple, pour une application vitrine ou similaire).
Tools
LanguageTool

[style] ~547-~547: Ce mot apparaît déjà dans l’une des phrases précédant immédiatement celle-ci. Utilisez un synonyme pour apporter plus de variété à votre texte, excepté si la répétition est intentionnelle.
Context: ...n (f.e. pour une application vitrine ou similaire). #### DisablePinchZoom Setting this ...

(FR_REPEATEDWORDS_SIMILAIRE)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fe9495d and bbb0290.

Files selected for processing (10)
  • website/docs/reference/options.mdx (2 hunks)
  • website/i18n/ar/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/fr/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/ja/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/ko/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/pt/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/ru/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/tr/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/vi/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
Files skipped from review due to trivial changes (8)
  • website/docs/reference/options.mdx
  • website/i18n/ar/docusaurus-plugin-content-docs/current/reference/options.mdx
  • website/i18n/ko/docusaurus-plugin-content-docs/current/reference/options.mdx
  • website/i18n/pt/docusaurus-plugin-content-docs/current/reference/options.mdx
  • website/i18n/ru/docusaurus-plugin-content-docs/current/reference/options.mdx
  • website/i18n/tr/docusaurus-plugin-content-docs/current/reference/options.mdx
  • website/i18n/vi/docusaurus-plugin-content-docs/current/reference/options.mdx
  • website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/reference/options.mdx
Additional context used
LanguageTool
website/i18n/ja/docusaurus-plugin-content-docs/current/reference/options.mdx

[uncategorized] ~547-~547: 「ことができる」という表現は冗長な可能性があります。
Context: ...: bool このオプションを有効にすると、拡大率をユーザによって変更することができます。 拡大率の変更がユーザに許可されていない間は、オプションで拡大率を設定する...

(DOUSI_KOTOGADEKIRU)


[uncategorized] ~547-~547: 「ことができる」という表現は冗長な可能性があります。
Context: ...きます。 拡大率の変更がユーザに許可されていない間は、オプションで拡大率を設定することができますのでご注意ください (例: キオスクアプリケーションなど)。 ####...

(DOUSI_KOTOGADEKIRU)

website/i18n/fr/docusaurus-plugin-content-docs/current/reference/options.mdx

[uncategorized] ~538-~538: Les deux-points sont précédés d’une espace insécable.
Context: ... | #### ZoomFactor Nom: ZoomFactor
Type: float64 Ceci d...

(FRENCH_WHITESPACE)


[uncategorized] ~539-~539: Les deux-points sont précédés d’une espace insécable.
Context: ... #### ZoomFactor Nom: ZoomFactor
Type: float64 Ceci définit le facteur de z...

(FRENCH_WHITESPACE)


[style] ~547-~547: Ce mot apparaît déjà dans l’une des phrases précédant immédiatement celle-ci. Utilisez un synonyme pour apporter plus de variété à votre texte, excepté si la répétition est intentionnelle.
Context: ...n (f.e. pour une application vitrine ou similaire). #### DisablePinchZoom Setting this ...

(FR_REPEATEDWORDS_SIMILAIRE)

Additional comments not posted (1)
website/i18n/ja/docusaurus-plugin-content-docs/current/reference/options.mdx (1)

537-542: Ensure clarity and completeness of ZoomFactor documentation.

The reintroduced documentation for ZoomFactor appears correct. However, consider adding more context or examples to help users unfamiliar with the option.

@levinit
Copy link
Contributor Author

levinit commented Jul 29, 2024

I am sorry there are 2 to in the commit msg 😢

@leaanthony
Copy link
Member

Thanks 🙏 Please could you add an entry to the changelog located at website/src/pages/changelog.mdx?

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (3)
website/i18n/ja/docusaurus-plugin-content-docs/current/reference/options.mdx (1)

543-547: Refine the description to avoid redundancy.

The phrase "ことができる" is redundant and can be simplified for clarity.

- このオプションを有効にすると、拡大率をユーザによって変更することができます。 拡大率の変更がユーザに許可されていない間は、オプションで拡大率を設定することができますのでご注意ください (例:  キオスクアプリケーションなど)。
+ このオプションを有効にすると、ユーザが拡大率を変更できます。 拡大率の変更が許可されていない場合でも、オプションで設定できます (例: キオスクアプリケーションなど)。
Tools
LanguageTool

[uncategorized] ~547-~547: 「ことができる」という表現は冗長な可能性があります。
Context: ...: bool このオプションを有効にすると、拡大率をユーザによって変更することができます。 拡大率の変更がユーザに許可されていない間は、オプションで拡大率を設定する...

(DOUSI_KOTOGADEKIRU)


[uncategorized] ~547-~547: 「ことができる」という表現は冗長な可能性があります。
Context: ...きます。 拡大率の変更がユーザに許可されていない間は、オプションで拡大率を設定することができますのでご注意ください (例: キオスクアプリケーションなど)。 ####...

(DOUSI_KOTOGADEKIRU)

website/i18n/fr/docusaurus-plugin-content-docs/current/reference/options.mdx (2)

537-542: Fix formatting issues with non-breaking spaces.

The colons should not be preceded by non-breaking spaces for consistency.

- Nom: ZoomFactor<br/> Type: `float64`
+ Nom : ZoomFactor<br/> Type : `float64`
Tools
LanguageTool

[uncategorized] ~538-~538: Les deux-points sont précédés d’une espace insécable.
Context: ... | #### ZoomFactor Nom: ZoomFactor
Type: float64 Ceci d...

(FRENCH_WHITESPACE)


[uncategorized] ~539-~539: Les deux-points sont précédés d’une espace insécable.
Context: ... #### ZoomFactor Nom: ZoomFactor
Type: float64 Ceci définit le facteur de z...

(FRENCH_WHITESPACE)


543-547: Avoid repetition for better readability.

The word "similaire" is repeated and can be replaced with a synonym to improve readability.

- Cela permet de modifier le facteur de zoom par l'utilisateur. Veuillez noter que le facteur de zoom peut être défini dans les options tandis que ne permet pas à l'utilisateur de le modifier à l'exécution (f.e. pour une application vitrine ou similaire).
+ Cela permet de modifier le facteur de zoom par l'utilisateur. Veuillez noter que le facteur de zoom peut être défini dans les options tandis que ne permet pas à l'utilisateur de le modifier à l'exécution (par exemple, pour une application vitrine ou comparable).
Tools
LanguageTool

[style] ~547-~547: Ce mot apparaît déjà dans l’une des phrases précédant immédiatement celle-ci. Utilisez un synonyme pour apporter plus de variété à votre texte, excepté si la répétition est intentionnelle.
Context: ...n (f.e. pour une application vitrine ou similaire). #### DisablePinchZoom Setting this ...

(FR_REPEATEDWORDS_SIMILAIRE)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bbb0290 and b5903e1.

Files selected for processing (11)
  • website/docs/reference/options.mdx (2 hunks)
  • website/i18n/ar/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/fr/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/ja/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/ko/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/pt/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/ru/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/tr/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/vi/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/src/pages/changelog.mdx (1 hunks)
Files skipped from review due to trivial changes (4)
  • website/i18n/ar/docusaurus-plugin-content-docs/current/reference/options.mdx
  • website/i18n/ko/docusaurus-plugin-content-docs/current/reference/options.mdx
  • website/i18n/ru/docusaurus-plugin-content-docs/current/reference/options.mdx
  • website/i18n/tr/docusaurus-plugin-content-docs/current/reference/options.mdx
Files skipped from review as they are similar to previous changes (4)
  • website/docs/reference/options.mdx
  • website/i18n/pt/docusaurus-plugin-content-docs/current/reference/options.mdx
  • website/i18n/vi/docusaurus-plugin-content-docs/current/reference/options.mdx
  • website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/reference/options.mdx
Additional context used
LanguageTool
website/i18n/ja/docusaurus-plugin-content-docs/current/reference/options.mdx

[uncategorized] ~547-~547: 「ことができる」という表現は冗長な可能性があります。
Context: ...: bool このオプションを有効にすると、拡大率をユーザによって変更することができます。 拡大率の変更がユーザに許可されていない間は、オプションで拡大率を設定する...

(DOUSI_KOTOGADEKIRU)


[uncategorized] ~547-~547: 「ことができる」という表現は冗長な可能性があります。
Context: ...きます。 拡大率の変更がユーザに許可されていない間は、オプションで拡大率を設定することができますのでご注意ください (例: キオスクアプリケーションなど)。 ####...

(DOUSI_KOTOGADEKIRU)

website/i18n/fr/docusaurus-plugin-content-docs/current/reference/options.mdx

[uncategorized] ~538-~538: Les deux-points sont précédés d’une espace insécable.
Context: ... | #### ZoomFactor Nom: ZoomFactor
Type: float64 Ceci d...

(FRENCH_WHITESPACE)


[uncategorized] ~539-~539: Les deux-points sont précédés d’une espace insécable.
Context: ... #### ZoomFactor Nom: ZoomFactor
Type: float64 Ceci définit le facteur de z...

(FRENCH_WHITESPACE)


[style] ~547-~547: Ce mot apparaît déjà dans l’une des phrases précédant immédiatement celle-ci. Utilisez un synonyme pour apporter plus de variété à votre texte, excepté si la répétition est intentionnelle.
Context: ...n (f.e. pour une application vitrine ou similaire). #### DisablePinchZoom Setting this ...

(FR_REPEATEDWORDS_SIMILAIRE)

Additional comments not posted (3)
website/i18n/ja/docusaurus-plugin-content-docs/current/reference/options.mdx (1)

537-542: Review the ZoomFactor section for clarity and accuracy.

The documentation for ZoomFactor is clear and correctly describes its purpose. However, ensure that the term "WebView2" is consistently used throughout the documentation.

website/src/pages/changelog.mdx (2)

21-21: Approve the phrasing correction for file drop events on Windows.

The change improves consistency and clarity in the changelog.


22-22: Approve the documentation update for ZoomFactor and IsZoomControlEnabled options.

The change clarifies that these options are Windows-only, aligning with the PR objectives.

@levinit
Copy link
Contributor Author

levinit commented Jul 29, 2024

Thanks 🙏 Please could you add an entry to the changelog located at website/src/pages/changelog.mdx?

I have modified the changelog.mdx, please check it, are there any other issues?

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b5903e1 and 851257c.

Files selected for processing (1)
  • website/src/pages/changelog.mdx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • website/src/pages/changelog.mdx

Copy link

sonarcloud bot commented Aug 18, 2024

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (3)
website/i18n/ja/docusaurus-plugin-content-docs/current/reference/options.mdx (1)

543-548: Consider revising redundant language.

The phrase "ことができる" appears twice and may be redundant. Consider simplifying the language for brevity.

- このオプションを有効にすると、拡大率をユーザによって変更することができます。 拡大率の変更がユーザに許可されていない間は、オプションで拡大率を設定することができますのでご注意ください
+ このオプションを有効にすると、ユーザが拡大率を変更できます。ユーザに許可されていない場合は、オプションで拡大率を設定してください

The repositioning of the IsZoomControlEnabled section improves the logical flow and accessibility of the documentation.

Tools
LanguageTool

[uncategorized] ~547-~547: 「ことができる」という表現は冗長な可能性があります。
Context: ...: bool このオプションを有効にすると、拡大率をユーザによって変更することができます。 拡大率の変更がユーザに許可されていない間は、オプションで拡大率を設定する...

(DOUSI_KOTOGADEKIRU)


[uncategorized] ~547-~547: 「ことができる」という表現は冗長な可能性があります。
Context: ...きます。 拡大率の変更がユーザに許可されていない間は、オプションで拡大率を設定することができますのでご注意ください (例: キオスクアプリケーションなど)。 ####...

(DOUSI_KOTOGADEKIRU)

website/i18n/fr/docusaurus-plugin-content-docs/current/reference/options.mdx (2)

537-542: Fix whitespace issue.

There is a non-breaking space before the colon in the description. Consider removing it for consistency.

- Nom : ZoomFactor<br/> Type : `float64`
+ Nom: ZoomFactor<br/> Type: `float64`

The repositioning of the ZoomFactor section enhances the logical flow and accessibility of the documentation. The description is clear and correctly conveys the functionality.

Tools
LanguageTool

[uncategorized] ~538-~538: Les deux-points sont précédés d’une espace insécable.
Context: ... | #### ZoomFactor Nom: ZoomFactor
Type: float64 Ceci d...

(FRENCH_WHITESPACE)


[uncategorized] ~539-~539: Les deux-points sont précédés d’une espace insécable.
Context: ... #### ZoomFactor Nom: ZoomFactor
Type: float64 Ceci définit le facteur de z...

(FRENCH_WHITESPACE)


543-548: Consider revising repeated words.

The word "similaire" is repeated. Consider using a synonym for variety unless the repetition is intentional.

- à l'exécution (f.e. pour une application vitrine ou similaire).
+ à l'exécution (par exemple, pour une application vitrine ou comparable).

The repositioning of the IsZoomControlEnabled section improves the logical flow and accessibility of the documentation. The description is clear and correctly conveys the functionality.

Tools
LanguageTool

[style] ~547-~547: Ce mot apparaît déjà dans l’une des phrases précédant immédiatement celle-ci. Utilisez un synonyme pour apporter plus de variété à votre texte, excepté si la répétition est intentionnelle.
Context: ...n (f.e. pour une application vitrine ou similaire). #### DisablePinchZoom Setting this ...

(FR_REPEATEDWORDS_SIMILAIRE)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 851257c and 6805311.

Files selected for processing (11)
  • website/docs/reference/options.mdx (2 hunks)
  • website/i18n/ar/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/fr/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/ja/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/ko/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/pt/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/ru/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/tr/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/vi/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/reference/options.mdx (2 hunks)
  • website/src/pages/changelog.mdx (1 hunks)
Files skipped from review due to trivial changes (9)
  • website/docs/reference/options.mdx
  • website/i18n/ar/docusaurus-plugin-content-docs/current/reference/options.mdx
  • website/i18n/ko/docusaurus-plugin-content-docs/current/reference/options.mdx
  • website/i18n/pt/docusaurus-plugin-content-docs/current/reference/options.mdx
  • website/i18n/ru/docusaurus-plugin-content-docs/current/reference/options.mdx
  • website/i18n/tr/docusaurus-plugin-content-docs/current/reference/options.mdx
  • website/i18n/vi/docusaurus-plugin-content-docs/current/reference/options.mdx
  • website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/reference/options.mdx
  • website/src/pages/changelog.mdx
Additional context used
LanguageTool
website/i18n/ja/docusaurus-plugin-content-docs/current/reference/options.mdx

[uncategorized] ~547-~547: 「ことができる」という表現は冗長な可能性があります。
Context: ...: bool このオプションを有効にすると、拡大率をユーザによって変更することができます。 拡大率の変更がユーザに許可されていない間は、オプションで拡大率を設定する...

(DOUSI_KOTOGADEKIRU)


[uncategorized] ~547-~547: 「ことができる」という表現は冗長な可能性があります。
Context: ...きます。 拡大率の変更がユーザに許可されていない間は、オプションで拡大率を設定することができますのでご注意ください (例: キオスクアプリケーションなど)。 ####...

(DOUSI_KOTOGADEKIRU)

website/i18n/fr/docusaurus-plugin-content-docs/current/reference/options.mdx

[uncategorized] ~538-~538: Les deux-points sont précédés d’une espace insécable.
Context: ... | #### ZoomFactor Nom: ZoomFactor
Type: float64 Ceci d...

(FRENCH_WHITESPACE)


[uncategorized] ~539-~539: Les deux-points sont précédés d’une espace insécable.
Context: ... #### ZoomFactor Nom: ZoomFactor
Type: float64 Ceci définit le facteur de z...

(FRENCH_WHITESPACE)


[style] ~547-~547: Ce mot apparaît déjà dans l’une des phrases précédant immédiatement celle-ci. Utilisez un synonyme pour apporter plus de variété à votre texte, excepté si la répétition est intentionnelle.
Context: ...n (f.e. pour une application vitrine ou similaire). #### DisablePinchZoom Setting this ...

(FR_REPEATEDWORDS_SIMILAIRE)

Additional comments not posted (1)
website/i18n/ja/docusaurus-plugin-content-docs/current/reference/options.mdx (1)

537-542: Reorganization improves clarity.

The repositioning of the ZoomFactor section enhances the logical flow and accessibility of the documentation. The description is clear and correctly conveys the functionality.

@leaanthony leaanthony merged commit d36d171 into wailsapp:master Aug 18, 2024
13 checks passed
@leaanthony
Copy link
Member

Thank you @levinit 🙏

therealsamf pushed a commit to therealsamf/wails that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IsZoomControlEnabled and ZoomFactor are windows only options
2 participants