Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to edit their own CSS and JS #458

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Allow users to edit their own CSS and JS #458

merged 3 commits into from
Nov 14, 2024

Conversation

AndrewKostka
Copy link
Contributor

@AndrewKostka AndrewKostka commented Nov 12, 2024 •
edited
Loading

Bug: T378627

tarrow
tarrow approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@tarrow tarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I locally confirmed that users can't edit the sitewide JS and that even the 'crat starting user can't edit other user's JS

@AndrewKostka AndrewKostka merged commit 608f2f8 into main Nov 14, 2024
9 checks passed
@AndrewKostka AndrewKostka deleted the allow-personal-scripts branch November 14, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrow tarrow tarrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewKostka @tarrow