Stanning for tests (#1288)

* property access * ignore never read, only written * use template args * ignore lines * Apply php-cs-fixer changes Co-authored-by: shmax <shmax@users.noreply.github.com>
webonyx · Jan 25, 2023 · ff7419b · ff7419b
1 parent fc6723f
commit ff7419b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 18 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -93,20 +93,4 @@ parameters:
 		-
 			message: "#^SplObjectStorage\\<GraphQL\\\\Language\\\\AST\\\\SelectionSetNode, array\\{array\\<string, array\\<int, array\\{GraphQL\\\\Type\\\\Definition\\\\Type, GraphQL\\\\Language\\\\AST\\\\FieldNode, GraphQL\\\\Type\\\\Definition\\\\FieldDefinition\\|null\\}\\>\\>, array\\<int, string\\>\\}\\> does not accept array\\<int, mixed\\>\\.$#"
 			count: 1
-			path: src/Validator/Rules/OverlappingFieldsCanBeMerged.php
-
-		-
-			message: "#^Method GraphQL\\\\Tests\\\\Language\\\\VisitorTest\\:\\:getNodeByPath\\(\\) return type with generic class GraphQL\\\\Language\\\\AST\\\\NodeList does not specify its types\\: T$#"
-			count: 1
-			path: tests/Language/VisitorTest.php
-
-		-
-			message: "#^Variable property access on mixed\\.$#"
-			count: 2
-			path: tests/Language/VisitorTest.php
-
-		-
-			message: "#^Property GraphQL\\\\Tests\\\\Type\\\\SchemaTest\\:\\:\\$implementingType is never read, only written\\.$#"
-			count: 1
-			path: tests/Type/SchemaTest.php
-
+			path: src/Validator/Rules/OverlappingFieldsCanBeMerged.php
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -62,6 +62,8 @@ parameters:
         # PHPStan does not play nicely with markTestSkipped()
         - message: "~Unreachable statement - code above always terminates~"
           path: tests
+        - message: "#^Property GraphQL\\\\Tests\\\\Type\\\\SchemaTest\\:\\:\\$implementingType is never read, only written\\.$#"
+          path: tests
 
 includes:
     - phpstan-baseline.neon

diff --git a/tests/Language/VisitorTest.php b/tests/Language/VisitorTest.php
@@ -68,6 +68,7 @@ private function checkVisitorFnArgs(DocumentNode $ast, array $args, bool $isEdit
         if ($parent instanceof NodeList) {
             self::assertEquals($node, $parent[$key]);
         } else {
+            /** @phpstan-ignore-next-line */
             self::assertEquals($node, $parent->{$key});
         }
 
@@ -82,7 +83,7 @@ private function checkVisitorFnArgs(DocumentNode $ast, array $args, bool $isEdit
     /**
      * @param array<string|int> $path
      *
-     * @return Node|NodeList
+     * @return Node|NodeList<SelectionNode&Node>
      */
     private function getNodeByPath(DocumentNode $ast, array $path): object
     {
@@ -92,6 +93,7 @@ private function getNodeByPath(DocumentNode $ast, array $path): object
             if ($result instanceof NodeList) {
                 $result = $result[$key];
             } else {
+                /** @phpstan-ignore-next-line */
                 $result = $result->{$key};
             }
         }