Implement new logger API #414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deb8d8f
to
58f6436
Compare
The new event API in Broker enables users to install custom event observers (loggers) in order to embed Broker logs into a wider context.
The new logging backend no longer offers trace logging. Since it is more geared towards high-level description of events rather than leaving a paper trail what lines of code ran.
The distinction between clones and masters at the log level component has proven to be too fine-grained and makes it difficult to log events outside of the master and clone actors, e.g., the store (base) actor or the channels.
|
Closes ##408. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the design outlined in #408. I've designed it in a way that allow us to easily switch to
std::formatonce we have access to it. Compared to the preliminary design in the ticket, I've merged the two store components back into one. There's also anappcategory, that I plan on using in some of our Broker tools. Broker itself won't use this component.If we can agree on this approach, I'd prepare a branch in Zeek that picks up the logs from Broker and puts them into
broker.log.