Add tags and capabilities to action definition #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Points to the main branch as the remote branch only exists on the fork
|
Thanks! I did some manual testing. We don't seem to have any tests here... |
|
@laduke Are you expecting to get this merged / released any time soon? No stress - I just want to know if I'm better off using our fork for the time being or if it's worth waiting to use upstream. Let me know if there is anything I can do from my end to speed up the process. Thanks! |
|
I've pinged others for a second opinion. I'm not really the expert on this one. Hard to guess on the timing. |
|
Hi there! Any news on merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ZeroTier network deployments make extensive use of tags and capabilities to segregate network access.
This PR introduces a way to specify the tags and capabilities to be attributed to the GitHub action runner upon creation.
(I do not expect the PR to pass automated tests as the tags and capabilities need to be already created on the test network and I could not find any test setup on the project)