Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add smoke-test for various node version and package managers #670

Merged
merged 21 commits into from
Oct 27, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use import for loading the addon
  • Loading branch information
aminya committed Oct 27, 2024
commit 14e9c5e7593fd79e01960c277b0a5599982f78c2
3 changes: 2 additions & 1 deletion lib/load-addon.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/load-addon.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion src/load-addon.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,5 @@ function findAddon(): any | undefined {
return addon
}

module.exports = findAddon()
const addon = findAddon()
export default addon
3 changes: 2 additions & 1 deletion src/native.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/* eslint-disable @typescript-eslint/no-var-requires */

/* Declare all native C++ classes and methods in this file. */
module.exports = require("./load-addon")
import addon from "./load-addon"
module.exports = addon

/**
* The version of the ØMQ library the bindings were built with. Formatted as
Expand Down