Skip to content

FIX style item.checkCircle.backgroundColor not work with original CheckRadioView && FIX CheckStyle && fix sumsung take photo crash bug:configuration changed cause MediaStoreCompat uri and path cleaned #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

FIX style item.checkCircle.backgroundColor not work with original CheckRadioView && FIX CheckStyle && fix sumsung take photo crash bug:configuration changed cause MediaStoreCompat uri and path cleaned #578

wants to merge 5 commits into from

Conversation

ThorWu
Copy link

@ThorWu ThorWu commented Mar 6, 2019

  1. fix sumsung take photo nullpointer exception crash bug:configuration changed cause MediaStoreCompat uri and path be cleaned,use saveInstanceState strategy to fix it.

  2. fix checkstyle fail : Caused by: java.io.FileNotFoundException: http://www.puppycrawl.com/dtds/configuration_1_3.dtd

    .gradlew checkstyle Fail

    Execution failed for task ':matisse:checkstyle'.
Unable to create Root Module: configLocation 
{~/Documents/AndroidDev/MatisseFork/Matisse/checkstyle.xml}, classpath {null}.```

@ThorWu ThorWu changed the title FIX CheckStyle && fix sumsung take photo crash bug:configuration changed cause MediaStoreCompat uri and path cleaned FIX style item.checkCircle.backgroundColor not work with original CheckRadioView && FIX CheckStyle && fix sumsung take photo crash bug:configuration changed cause MediaStoreCompat uri and path cleaned Mar 23, 2019
@ThorWu
Copy link
Author

ThorWu commented Mar 23, 2019 •
edited
Loading

add TypeArray in CheckRadioView.java method init()

to Fix bug:

 <style name="Matisse_Custom" parent="Matisse.Zhihu"> 
        <item name="item.checkCircle.backgroundColor">@color/colorCustom</item>
 </style>

not work with CheckRadioView original.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@xuhaoyang xuhaoyang xuhaoyang approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThorWu @xuhaoyang