-
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add support for color
input
#37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Kusari Analysis Results:
No pinned version dependency changes, code issues or exposed secrets detected!
Found this helpful? Give it a 👍 or 👎 reaction! |
Kusari PR Analysis rerun based on - d979586 performed at: 2025-08-26T09:52:24Z - link to updated analysis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @birjj, this looks great to me. Could you add it to the inputs section of the README as well?
Thanks for calling this out -- I think this'll be fine, since zizmor's official images don't even support versions before 1.5.2 🙂 |
Kusari PR Analysis rerun based on - 435d97b performed at: 2025-08-27T09:35:02Z - link to updated analysis |
Kusari PR Analysis rerun based on - 960f52e performed at: 2025-08-27T10:06:06Z - link to updated analysis |
Done, good catch 👍 I've also gone ahead and refactored the inputs so it's now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This adds support for the
color
input, which maps to the--color
parameter for Zizmor. This allows callers to control whether the colorization should happen or not. Fixes #36.I wasn't sure if we wanted to standardize oncolor: false
to disable colors, orcolor: never
which aligns withzizmor
's parameter. I ended up aligning withzizmor
, but have found it to be slightly confusing for people who are more used to GHA 🤷 I'll let it be up to the maintainer to decide, but am happy to implement whatever we land on.I chose to revert this design. It looks like the rest of the inputs are designed to be inputs to the action, not to
zizmor
itself, so it makes more sense to havecolor: false
thancolor: never
("never" being nonsensical for the action).As part of implementing this I have switched from the current hardcoded
FORCE_COLOR=1
env variable to passing--color=always
by default. As far as I understand this should have no functional difference, other than version support (with--color
being supported from v1.5.0+ of Zizmor). I'm unsure if that incompatibility with old versions is worth working around.