Pull zlib 1.3 changes #1563
Merged
Pull zlib 1.3 changes #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment said that the os is set to 255, when in fact it has been set to the current os since zlib 1.2.3. Or at least our best guess at the os made at compile time.
and Reset functions.
zlib does not use time_t, so _TIME_BITS is irrelevant. However it may be defined anyway as part of a sledgehammer indiscriminately applied to all builds.
|
One thing I noticed was that zlib header comments at one point were changed to mention |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1563 +/- ##
===========================================
+ Coverage 83.86% 83.90% +0.03%
===========================================
Files 132 132
Lines 10843 10843
Branches 2801 2801
===========================================
+ Hits 9094 9098 +4
+ Misses 1050 1047 -3
+ Partials 699 698 -1 Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Perhaps also update the zlib-compat version in this PR, to ensure consistency? |
phprus
reviewed
Aug 23, 2023
1ddbeda
to
ec91210
Compare
|
Thanks for handling this @nmoinvaz 🥇 |
Merged
FantasqueX
added a commit
to FantasqueX/zlib-ng
that referenced
this pull request
Dec 18, 2023
zlib-ng#1563 this patch forgets to update copyright string.
Dead2
pushed a commit
that referenced
this pull request
Dec 20, 2023
#1563 this patch forgets to update copyright string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.