Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the SSL plugin work within the Linux based Docker container #594

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

matyasmarkovics
Copy link

No description provided.

@z3APA3A
Copy link
Collaborator

z3APA3A commented Feb 5, 2021

Can you change few things for pull to be accepted pls:

  1. for _set_errno add
#else
errno = ...

Or replace this fix with

#ifndef _set_errno
#define _set_errno(x) (errno = x)
#endif

in #ifndef _WIN32 section of proxy.h

  1. For no shared cipher - I'm not sure it's a best fix, it's a bit strange. May be first commenter on stackoverflow is right and limiting the TLS version is actually required.

@matyasmarkovics
Copy link
Author

Thanks @z3APA3A, I've applied y our comment on _set_errno. I've only found #ifdef _WIN32, so I've added an #else to it. Hope that's fine.

After researching the no-shared-cipher issue more, I've decided to exclude it.
I got this message: error:142090C1:SSL routines:tls_early_post_process_client_hello:no shared cipher.
Despite the message the request goes through (maybe on a 2nd attempt).

I've tried the suggested change: const long flags = SSL_OP_NO_SSLv2 | SSL_OP_NO_SSLv3 | SSL_OP_NO_COMPRESSION;...., but it didn't make a difference. Maybe the issue is with my certificates.

Anyway, this PR makes the SSL-plugin functional for me within the docker. Thanks for the feedback!

@matyasmarkovics
Copy link
Author

Any remaining issues you see on this @z3APA3A ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants