Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Support non-netplan Ubuntu #63

Closed
89luca89 opened this issue Jan 29, 2021 · 0 comments · Fixed by #66
Closed

[IMPROVEMENT] Support non-netplan Ubuntu #63

89luca89 opened this issue Jan 29, 2021 · 0 comments · Fixed by #66
Assignees
@89luca89
Labels
enhancement New feature or request experimental This issue needs a deep research and some improvement evaluation good first issue Good for newcomers help wanted Extra attention is needed
Milestone
1.3.0

Comments

@89luca89
Copy link
Owner

Right now, we are taking for granted that Ubuntu uses netplan.

This is not strictly true, for various reasons:

  • custom image from the user, removing netplan
  • older versions of ubuntu

We should improve the netplan detection itself instead of relying on ubuntu-vs-debian definition
@89luca89 89luca89 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers experimental This issue needs a deep research and some improvement evaluation labels Jan 29, 2021
@89luca89 89luca89 added this to the 1.3.0 milestone Jan 29, 2021
@89luca89 89luca89 self-assigned this Jan 29, 2021
@89luca89 89luca89 mentioned this issue Jan 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@89luca89 89luca89

Labels
enhancement New feature or request experimental This issue needs a deep research and some improvement evaluation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

WIP: Improving netplan detection, using package manager 89luca89/terrible
1 participant
@89luca89