Page MenuHomePhabricator

Add support for (the equivalent of?) editintro and preload
Closed, ResolvedPublic8 Estimated Story Points

Description

In VE, new users may use tutorials/wizards which use editintro/preload features, which aren't supported by the visual editor yet.

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Quiddity added subscribers: Cenarium, TheDJ.

I've merged the above, and copied the details into the description above.

nominating this as Q1 blocker, since this is closely tied to the current BLP practices on english wikipedia, a very visible and sensitive part of our policies.

We've encountered this issue too on a private MediaWiki.
Would be really great to have this supported - this would make the VE more versatile in some use cases!

Thanks!

These tasks *really* shouldn't have been merged, despite being about 'the same' area of code (one is about important functionality half done through on-wiki hacky JavaScript, the other is about modifying a fundamental user pattern in core to work with VisualEditor); un-merging.

Jdforrester-WMF renamed this task from VisualEditor: Add support for (the equivalent of?) editintro and preload to Add support for (the equivalent of?) editintro and preload.Jun 22 2015, 3:09 PM
Jdforrester-WMF lowered the priority of this task from Medium to Lowest.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added a subscriber: Tpt.

A note from @Tpt that this is pretty important for successful ProofreadPage integration.

Jdforrester-WMF raised the priority of this task from Lowest to Medium.Jun 23 2016, 2:58 PM
Jdforrester-WMF set the point value for this task to 8.

Thomas's suggestion is that if the article is a 404 (non-extant), we sling the contents of preload parameter's indicated article's Parsoid blob as the initial version of the article, and if that's not balanced wikitext (and so not the desired HTML) "oh well", at least it's better than nothing. Thoughts?

Tpt removed a project: ProofreadPage.

ProofreadPage needs support of the EditFormPreloadText hook instead of editinfo/preload parameters. Tracked by task T138588

It looks like there are similar problems on Mobile view, which may be of interest to anyone who is relying on preload: T126190: Preload does not work correctly on mobile view

VisualEditor having preload support for page creation would be nice. Preload is used in article wizards (e.g. en-wp, ru-wp).

Change 329796 had a related patch set uploaded (by Esanders):
Add editintro to notices

https://gerrit.wikimedia.org/r/329796

Change 329796 merged by jenkins-bot:
Add editintro to notices

https://gerrit.wikimedia.org/r/329796

This would be very useful for the Wikidebate project at Wikiversity.

Change 378343 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] Enable preload in VisualEditor

https://gerrit.wikimedia.org/r/378343

That patch is very much the "better than nothing" version James suggested. It pulls the article, substitutes in the parameters, and then if it's in visual mode it runs it through Parsoid. It should be functionally-equivalent for the 2017 wikitext editor, though, since that doesn't rely on always containing valid documents.

Change 378726 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget: Support preloadtitle in source mode

https://gerrit.wikimedia.org/r/378726

Change 378726 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget: Support preloadtitle in source mode

https://gerrit.wikimedia.org/r/378726

Change 378343 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Enable preload in VisualEditor

https://gerrit.wikimedia.org/r/378343

Deskana subscribed.

What is the best way to test this?

I tried using Template:Submit an edit request on the beta cluster, which appears to use preloading, but it kicked me straight in to the 2010 editor even though I've got the 2017 editor beta feature enabled. I don't even know where I'd begin to test it in the visual editor.

Change 379246 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] Hooks: remove preloadtitle from unsupported list

https://gerrit.wikimedia.org/r/379246

Change 379246 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Hooks: remove preloadtitle from unsupported list

https://gerrit.wikimedia.org/r/379246

Just to confirm, now that patch has made its way to the beta cluster, the inputbox button works and gets us this:

image.png (668×1 px, 76 KB)

Change 380530 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] Api: include preload content when section=new

https://gerrit.wikimedia.org/r/380530

Change 380530 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Api: include preload content when section=new

https://gerrit.wikimedia.org/r/380530