Page MenuHomePhabricator
Create Task
Maniphest T102614

Fix Generic.Files.LineLength errors in MediaWiki core by breaking long lines
Closed, ResolvedPublic
Actions

Description

Line length should not be more than 100 characters.

Sniff output at P790.
Newer sniff output at P814 (ignoring languages/ completely).

Summary:

...........W............W........WW..W..W......W......WW..W.   60 / 1909 (3%)
WWWWWWW..W.WW.WWWW..W...W..W..WWW...W..WW...W...W.....WW.WW.  120 / 1909 (6%)
WWW...W....W.WW..W..W.W.WW..WW......WW...W....W..W..WWW.WW.W  180 / 1909 (9%)
..W.W.W.WW...W.....WWWWWWW...W.........W.......W.W..W.W.....  240 / 1909 (13%)
W.W...W..WWW.....W.WW.....WW.WWW.W...WWW..W..WWWWW...W.W....  300 / 1909 (16%)
WWW.WW.WWWW...W..W.WWW.W.WWW.......W....W...W..WW.W.W.WWW..W  360 / 1909 (19%)
..W.......WW.........W..............W..W.............W......  420 / 1909 (22%)
...................WW...........W...........................  480 / 1909 (25%)
............................................................  540 / 1909 (28%)
W......W....................W.......................W.......  600 / 1909 (31%)
................W.WW........................................  660 / 1909 (35%)
.........................W.....W...W........W...............  720 / 1909 (38%)
.............W.....WW.......W..................WWW.WW.......  780 / 1909 (41%)
.W...W..........W........................................WWW  840 / 1909 (44%)
..............................W................W.......W...W  900 / 1909 (47%)
.................W...W.....W..W..WWWWW.WWW.....W.W..W.......  960 / 1909 (50%)
...W.W.........W............W............................... 1020 / 1909 (53%)
........................S...............................W... 1080 / 1909 (57%)
......WW..W..........................W.....W........W.....W. 1140 / 1909 (60%)
..............................................W............. 1200 / 1909 (63%)
...........W...............W..WW............................ 1260 / 1909 (66%)
.........W.................................................. 1320 / 1909 (69%)
........................................................W... 1380 / 1909 (72%)
.......................................................W...W 1440 / 1909 (75%)
..W.W.....W..W................................W....W.......W 1500 / 1909 (79%)
.............W.W.............W.................W............ 1560 / 1909 (82%)
..............W..W....W.........W............W.W...W.....W.. 1620 / 1909 (85%)
.............W.........WW..W....W.W....W.............W.W..W. 1680 / 1909 (88%)
.................WW...W.......W.....W....................... 1740 / 1909 (91%)
................W........W.SS................S.............. 1800 / 1909 (94%)
..........W................WWS...WW.......W................W 1860 / 1909 (97%)
........W....W..W................W.........W.W...

Newer summary (ignoring languages/ completely):

..................W..........................W..............   60 / 1450 (4%)
............................................................  120 / 1450 (8%)
........................W...........................W.......  180 / 1450 (12%)
................W.......................W.WW................  240 / 1450 (17%)
.W...W........W............................W.....WW.......W.  300 / 1450 (21%)
.................WW.W.WW........W...W..........W............  360 / 1450 (25%)
............................WWW.............................  420 / 1450 (29%)
.W..............W.......W.....................W...W.....W..W  480 / 1450 (33%)
..WWWWW.WWW.....W.W..W..........W.W.........W............W..  540 / 1450 (37%)
.....................................................S......  600 / 1450 (41%)
.........................W.........WW.......................  660 / 1450 (46%)
......W.....W........W.....W................................  720 / 1450 (50%)
...............W........................W...................  780 / 1450 (54%)
......................................W.....................  840 / 1450 (58%)
............................................................  900 / 1450 (62%)
.........................W..................................  960 / 1450 (66%)
........................W...W..W.W.....W..W................. 1020 / 1450 (70%)
...............W....W.......W.............W.W.............W. 1080 / 1450 (74%)
.....W...........................W..W....W..........W....... 1140 / 1450 (79%)
......W.W...W.....W...............W.........WW..W....W.W.... 1200 / 1450 (83%)
W.............W.W..W..................WW...W.......W.....W.. 1260 / 1450 (87%)
.....................................W........W.SS.......... 1320 / 1450 (91%)
......S........................W................WWS...WW.... 1380 / 1450 (95%)
...W................W........W....W..W................W..... 1440 / 1450 (99%)
......W...

Details

SubjectRepoBranchLines +/-
Reenable LineLength phpcs checkmediawiki/coremaster+0 -1
Fix long line to make phpcs passmediawiki/coremaster+2 -1
Fix the last Generic.Files.LineLength phpcs failuresmediawiki/coremaster+5 -5
Re-enable Generic.Files.LineLength and exclude failing filesmediawiki/coremaster+6 -1
Fix remaining Generic.Files.LineLength failuresmediawiki/coremaster+46 -14
Fix Generic.Files.LineLength phpcs check under phpunit/includes/apimediawiki/coremaster+241 -57
Fix Generic.Files.LineLength phpcs check in files under phpunit/includesmediawiki/coremaster+60 -19
Fix Generic.Files.LineLength phpcs failure in 11 files under includes/mediawiki/coremaster+57 -18
Make lines short to pass phpcs in WikiReferenceTest.phpmediawiki/coremaster+96 -12
Make lines short to pass phpcs in WikitextContentTest.phpmediawiki/coremaster+35 -10
Add @codingStandardsIgnoreStart to 5 files under tests/phpunit/includesmediawiki/coremaster+16 -2
Make lines short to pass phpcs in media tests PHP filesmediawiki/coremaster+61 -13
Make lines short to pass phpcs in parser tests PHP filesmediawiki/coremaster+11 -3
Make lines short to pass phpcs in 3 files under tests/phpunit/includes/mediawiki/coremaster+42 -11
Make lines short to pass phpcs in 2 files under tests/phpunit/includes/mediawiki/coremaster+46 -8
Make lines short to pass phpcs in BagOStuffTest.phpmediawiki/coremaster+5 -2
Make lines short to pass phpcs in ResourcesTest.phpmediawiki/coremaster+8 -1
Make lines short to pass phpcs in files under includes/api/mediawiki/coremaster+103 -30
Make lines short to pass phpcs in 2 files under includes/mediawiki/coremaster+20 -4
Make lines short to pass phpcs in testHelpers.incmediawiki/coremaster+5 -2
Rewrite comments on member variables of ParserOutput as proper variables documentationmediawiki/coremaster+192 -37
Make lines short to pass phpcs in profileinfo.phpmediawiki/coremaster+37 -11
Make lines short to pass phpcs in files under includes/resourceloadermediawiki/coremaster+13 -3
Make lines short to pass phpcs in files under includes/mediawiki/coremaster+7 -3
Make lines short to pass phpcs in files under includes/db/mediawiki/coremaster+14 -5
Make lines short to pass phpcs in files under maintenance/mediawiki/coremaster+36 -11
Make lines short to pass phpcs in OutputPage.phpmediawiki/coremaster+39 -16
Make lines short to pass phpcs in KafkaHandler.phpmediawiki/coremaster+6 -2
Make lines short to pass phpcs in Language.phpmediawiki/coremaster+8 -3
Make lines shorter to pass phpcs in thumb.phpmediawiki/coremaster+18 -7
Make lines short to pass phpcs in six files under includes/mediawiki/coremaster+42 -21
Make lines shorter to pass phpcs under includes/libsmediawiki/coremaster+14 -2
Make line shorter to pass phpcs in LinkerTest.phpmediawiki/coremaster+3 -1
Make lines shorter to pass phpcs in some files under includes/parsermediawiki/coremaster+67 -29
Make long lines shorter to pass phpcs in 6 filesmediawiki/coremaster+25 -7
Linker.php: Make long lines shorter to pass phpcsmediawiki/coremaster+38 -16
Fix LineLength in includes/mediamediawiki/coremaster+32 -14
Fix phpcs warningsmediawiki/coremaster+59 -22
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Sep 27 2015, 8:15 AM

Change 241509 had a related patch set uploaded (by Amire80):
Make lines short to pass phpcs in files under includes/db/

https://gerrit.wikimedia.org/r/241509

gerritbot added a comment.Sep 27 2015, 1:07 PM

Change 241520 had a related patch set uploaded (by Amire80):
Make lines short to pass phpcs in files under includes/api/

https://gerrit.wikimedia.org/r/241520

gerritbot added a comment.Sep 27 2015, 1:13 PM

Change 241521 had a related patch set uploaded (by Amire80):
Make lines short to pass phpcs in files in ParserOutput.php

https://gerrit.wikimedia.org/r/241521

gerritbot added a comment.Sep 27 2015, 2:17 PM

Change 241503 merged by jenkins-bot:
Make lines short to pass phpcs in Language.php

https://gerrit.wikimedia.org/r/241503

Amire80 mentioned this in rMW50f546aa3e89: Make lines short to pass phpcs in Language.php.Sep 27 2015, 2:18 PM
gerritbot added a comment.Sep 27 2015, 2:30 PM

Change 241506 merged by jenkins-bot:
Make lines short to pass phpcs in KafkaHandler.php

https://gerrit.wikimedia.org/r/241506

Reedy mentioned this in rMWf6cf64e10e1d: Make lines short to pass phpcs in KafkaHandler.php.Sep 27 2015, 2:30 PM
gerritbot added a comment.Sep 27 2015, 2:49 PM

Change 241505 merged by jenkins-bot:
Make lines short to pass phpcs in OutputPage.php

https://gerrit.wikimedia.org/r/241505

Reedy mentioned this in rMWa0f33b188a29: Make lines short to pass phpcs in OutputPage.php.Sep 27 2015, 2:49 PM
gerritbot added a comment.Sep 27 2015, 3:58 PM

Change 241502 merged by jenkins-bot:
Make lines short to pass phpcs in files under maintenance/

https://gerrit.wikimedia.org/r/241502

Umherirrender mentioned this in rMW34a07796c16a: Make lines short to pass phpcs in files under maintenance/.Sep 27 2015, 3:58 PM
gerritbot added a comment.Sep 27 2015, 4:09 PM

Change 241509 merged by jenkins-bot:
Make lines short to pass phpcs in files under includes/db/

https://gerrit.wikimedia.org/r/241509

Umherirrender mentioned this in rMW6b7c6e9be919: Make lines short to pass phpcs in files under includes/db/.Sep 27 2015, 4:09 PM
gerritbot added a comment.Sep 27 2015, 4:21 PM

Change 241508 merged by jenkins-bot:
Make lines short to pass phpcs in files under includes/

https://gerrit.wikimedia.org/r/241508

Umherirrender mentioned this in rMW9f4c89519067: Make lines short to pass phpcs in files under includes/.Sep 27 2015, 4:21 PM
gerritbot added a comment.Sep 27 2015, 4:34 PM

Change 241507 merged by jenkins-bot:
Make lines short to pass phpcs in files under includes/resourceloader

https://gerrit.wikimedia.org/r/241507

Umherirrender mentioned this in rMW4e7cc78b4f17: Make lines short to pass phpcs in files under includes/resourceloader.Sep 27 2015, 4:34 PM
gerritbot added a comment.Sep 27 2015, 5:14 PM

Change 241504 merged by Umherirrender:
Make lines short to pass phpcs in profileinfo.php

https://gerrit.wikimedia.org/r/241504

Umherirrender mentioned this in rMW586c39a8d585: Make lines short to pass phpcs in profileinfo.php.Sep 27 2015, 5:14 PM
gerritbot added a comment.Sep 28 2015, 11:42 AM

Change 241629 had a related patch set uploaded (by Amire80):
Make lines short to pass phpcs in testHelpers.inc

https://gerrit.wikimedia.org/r/241629

gerritbot added a comment.Sep 28 2015, 12:16 PM

Change 241521 merged by jenkins-bot:
Rewrite comments on member variables of ParserOutput as proper variables documentation

https://gerrit.wikimedia.org/r/241521

Amire80 mentioned this in rMW4841ede9c3f7: Rewrite comments on member variables of ParserOutput as proper variables….Sep 28 2015, 12:16 PM
gerritbot added a comment.Sep 28 2015, 12:17 PM

Change 241629 merged by jenkins-bot:
Make lines short to pass phpcs in testHelpers.inc

https://gerrit.wikimedia.org/r/241629

Amire80 mentioned this in rMWdeabc006bc73: Make lines short to pass phpcs in testHelpers.inc.Sep 28 2015, 12:18 PM
gerritbot added a comment.Sep 28 2015, 12:44 PM

Change 241644 had a related patch set uploaded (by Amire80):
Make lines short to pass phpcs in 2 files under includes/

https://gerrit.wikimedia.org/r/241644

ReleaseTaggerBot added projects: MW-1.27-release, MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 9:24 PM
greg edited projects, added MW-1.27-release-notes; removed MW-1.27-release.Sep 29 2015, 10:28 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:49 AM
gerritbot added a comment.Sep 30 2015, 5:29 AM

Change 241644 merged by jenkins-bot:
Make lines short to pass phpcs in 2 files under includes/

https://gerrit.wikimedia.org/r/241644

Umherirrender mentioned this in rMWddbba62d03e8: Make lines short to pass phpcs in 2 files under includes/.Sep 30 2015, 5:32 AM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 6:00 AM
Amire80 triaged this task as Low priority.Sep 30 2015, 6:03 AM
gerritbot added a comment.Sep 30 2015, 6:09 AM

Change 242444 had a related patch set uploaded (by Amire80):
Make lines short to pass phpcs in parser tests PHP files

https://gerrit.wikimedia.org/r/242444

gerritbot added a comment.Sep 30 2015, 6:17 AM

Change 242445 had a related patch set uploaded (by Amire80):
Make lines short to pass phpcs in media tests PHP files

https://gerrit.wikimedia.org/r/242445

gerritbot added a comment.Sep 30 2015, 6:18 AM

Change 241520 abandoned by Amire80:
Make lines short to pass phpcs in files under includes/api/

https://gerrit.wikimedia.org/r/241520

Amire80 added a subtask: T114213: @codingStandardsIgnoreStart only works with some types of comments.Sep 30 2015, 6:24 AM
gerritbot added a comment.Sep 30 2015, 8:16 AM

Change 242480 had a related patch set uploaded (by Amire80):
Make lines short to pass phpcs in ResourcesTest.php

https://gerrit.wikimedia.org/r/242480

gerritbot added a comment.Sep 30 2015, 8:16 AM

Change 242481 had a related patch set uploaded (by Amire80):
Make lines short to pass phpcs in BagOStuffTest.php

https://gerrit.wikimedia.org/r/242481

gerritbot added a comment.Sep 30 2015, 8:16 AM

Change 242482 had a related patch set uploaded (by Amire80):
Make lines short to pass phpcs in 2 files under tests/phpunit/includes/

https://gerrit.wikimedia.org/r/242482

gerritbot added a comment.Sep 30 2015, 8:16 AM

Change 242484 had a related patch set uploaded (by Amire80):
Make lines short to pass phpcs in 3 files under tests/phpunit/includes/

https://gerrit.wikimedia.org/r/242484

gerritbot added a comment.Sep 30 2015, 3:50 PM

Change 242480 merged by jenkins-bot:
Make lines short to pass phpcs in ResourcesTest.php

https://gerrit.wikimedia.org/r/242480

Umherirrender mentioned this in rMW9f5c3c1520a8: Make lines short to pass phpcs in ResourcesTest.php.Sep 30 2015, 3:51 PM
gerritbot added a comment.Sep 30 2015, 4:16 PM

Change 242481 merged by jenkins-bot:
Make lines short to pass phpcs in BagOStuffTest.php

https://gerrit.wikimedia.org/r/242481

Umherirrender mentioned this in rMWb59ad5811be7: Make lines short to pass phpcs in BagOStuffTest.php.Sep 30 2015, 4:19 PM
gerritbot added a comment.Sep 30 2015, 4:27 PM

Change 242482 merged by jenkins-bot:
Make lines short to pass phpcs in 2 files under tests/phpunit/includes/

https://gerrit.wikimedia.org/r/242482

Umherirrender mentioned this in rMWf9d0c98e16c6: Make lines short to pass phpcs in 2 files under tests/phpunit/includes/.Sep 30 2015, 4:29 PM
Legoktm closed subtask T114213: @codingStandardsIgnoreStart only works with some types of comments as Invalid.Oct 1 2015, 2:30 AM
Legoktm closed subtask T113852: @codingStandardsIgnoreStart doesn't seem to help avoid phpcs errors inside comments as Invalid.
gerritbot added a comment.Oct 1 2015, 7:10 PM

Change 242484 merged by jenkins-bot:
Make lines short to pass phpcs in 3 files under tests/phpunit/includes/

https://gerrit.wikimedia.org/r/242484

Umherirrender mentioned this in rMW3cd3b7ac9ffa: Make lines short to pass phpcs in 3 files under tests/phpunit/includes/.Oct 1 2015, 7:11 PM
Amire80 reopened subtask T114213: @codingStandardsIgnoreStart only works with some types of comments as Open.Oct 1 2015, 7:38 PM
gerritbot added a comment.Oct 1 2015, 7:52 PM

Change 242444 merged by jenkins-bot:
Make lines short to pass phpcs in parser tests PHP files

https://gerrit.wikimedia.org/r/242444

Amire80 mentioned this in rMW715abaa6b6c1: Make lines short to pass phpcs in parser tests PHP files.Oct 1 2015, 7:53 PM
gerritbot added a comment.Oct 1 2015, 7:58 PM

Change 242445 merged by jenkins-bot:
Make lines short to pass phpcs in media tests PHP files

https://gerrit.wikimedia.org/r/242445

Amire80 mentioned this in rMWdc71f6cf02dc: Make lines short to pass phpcs in media tests PHP files.Oct 1 2015, 7:59 PM
gerritbot added a comment.Oct 1 2015, 8:24 PM

Change 243016 had a related patch set uploaded (by Amire80):
Add @codingStandardsIgnoreStart to 5 files under tests/phpunit/includes

https://gerrit.wikimedia.org/r/243016

gerritbot added a comment.Oct 1 2015, 8:24 PM

Change 243017 had a related patch set uploaded (by Amire80):
Make lines short to pass phpcs in WikitextContentTest.php

https://gerrit.wikimedia.org/r/243017

gerritbot added a comment.Oct 1 2015, 8:24 PM

Change 243018 had a related patch set uploaded (by Amire80):
Make lines short to pass phpcs in WikiReferenceTest.php

https://gerrit.wikimedia.org/r/243018

gerritbot added a comment.Oct 3 2015, 12:55 PM

Change 243385 had a related patch set uploaded (by Amire80):
Fix Generic.Files.LineLength phpcs failure in 11 files under includes/

https://gerrit.wikimedia.org/r/243385

gerritbot added a comment.Oct 3 2015, 1:05 PM

Change 243386 had a related patch set uploaded (by Amire80):
Fix Generic.Files.LineLength phpcs check in 11 files under tests/phpunit/includes/

https://gerrit.wikimedia.org/r/243386

gerritbot added a comment.Oct 3 2015, 1:45 PM

Change 243392 had a related patch set uploaded (by Amire80):
Fix Generic.Files.LineLength phpcs check in 13 files under tests/phpunit/includes/api

https://gerrit.wikimedia.org/r/243392

gerritbot added a comment.Oct 3 2015, 1:45 PM

Change 243393 had a related patch set uploaded (by Amire80):
Fix Generic.Files.LineLength phpcs check in 10 files under tests/phpunit/includes/

https://gerrit.wikimedia.org/r/243393

Amire80 added subscribers: matmarex, Umherirrender, Anomie and 3 others.Oct 3 2015, 4:23 PM

AN ACTUAL UPDATE

The chain of patches from https://gerrit.wikimedia.org/r/#/c/243016/ until https://gerrit.wikimedia.org/r/#/c/243393/ fixes most of the remaining failures.

Thanks to @Umherirrender, @Reedy, @siebrand, @Jdforrester-WMF, @Legoktm, @Anomie, @polybuildr, @matmarex and everybody else who helped review it.

What's remaining, however, is the two failures that are described at T114213. I'm not sure how to resolve it because I'm not a real phpcs expert. Shall we ignore the failing files till there's an upstream solution?

gerritbot added a comment.Oct 3 2015, 4:37 PM

Change 243016 merged by jenkins-bot:
Add @codingStandardsIgnoreStart to 5 files under tests/phpunit/includes

https://gerrit.wikimedia.org/r/243016

Amire80 mentioned this in rMWe77af93e836e: Add @codingStandardsIgnoreStart to 5 files under tests/phpunit/includes.Oct 3 2015, 4:38 PM
gerritbot added a comment.Oct 3 2015, 4:39 PM

Change 243017 merged by jenkins-bot:
Make lines short to pass phpcs in WikitextContentTest.php

https://gerrit.wikimedia.org/r/243017

Amire80 mentioned this in rMWd461d5c8afff: Make lines short to pass phpcs in WikitextContentTest.php.Oct 3 2015, 4:40 PM
gerritbot added a comment.Oct 3 2015, 4:47 PM

Change 243018 merged by jenkins-bot:
Make lines short to pass phpcs in WikiReferenceTest.php

https://gerrit.wikimedia.org/r/243018

Amire80 mentioned this in rMW149d16d597b0: Make lines short to pass phpcs in WikiReferenceTest.php.Oct 3 2015, 4:47 PM
gerritbot added a comment.Oct 3 2015, 5:18 PM

Change 243385 merged by jenkins-bot:
Fix Generic.Files.LineLength phpcs failure in 11 files under includes/

https://gerrit.wikimedia.org/r/243385

Umherirrender mentioned this in rMWc37d6549fdff: Fix Generic.Files.LineLength phpcs failure in 11 files under includes/.Oct 3 2015, 5:18 PM
gerritbot added a comment.Oct 3 2015, 5:32 PM

Change 243386 merged by jenkins-bot:
Fix Generic.Files.LineLength phpcs check in files under phpunit/includes

https://gerrit.wikimedia.org/r/243386

gerritbot added a comment.Oct 3 2015, 5:32 PM

Change 243392 merged by jenkins-bot:
Fix Generic.Files.LineLength phpcs check under phpunit/includes/api

https://gerrit.wikimedia.org/r/243392

Umherirrender mentioned this in rMWbfdd3369c26b: Fix Generic.Files.LineLength phpcs check in files under phpunit/includes.Oct 3 2015, 5:32 PM
Umherirrender mentioned this in rMW94068c3e8113: Fix Generic.Files.LineLength phpcs check under phpunit/includes/api.
gerritbot added a comment.Oct 3 2015, 6:00 PM

Change 243393 merged by jenkins-bot:
Fix remaining Generic.Files.LineLength failures

https://gerrit.wikimedia.org/r/243393

Umherirrender mentioned this in rMWc50cbe48ab60: Fix remaining Generic.Files.LineLength failures.Oct 3 2015, 6:00 PM
gerritbot added a comment.Oct 3 2015, 6:06 PM

Change 243418 had a related patch set uploaded (by Amire80):
Fix the last Generic.Files.LineLength phpcs failures

https://gerrit.wikimedia.org/r/243418

gerritbot added a comment.Oct 5 2015, 8:26 AM

Change 243616 had a related patch set uploaded (by Amire80):
Re-enable Generic.Files.LineLength and exclude failing files

https://gerrit.wikimedia.org/r/243616

gerritbot added a comment.Oct 5 2015, 12:39 PM

Change 243418 merged by jenkins-bot:
Fix the last Generic.Files.LineLength phpcs failures

https://gerrit.wikimedia.org/r/243418

Reedy mentioned this in rMW4490b5b5ec4b: Fix the last Generic.Files.LineLength phpcs failures.Oct 5 2015, 12:40 PM
gerritbot added a comment.Oct 5 2015, 12:41 PM

Change 243616 abandoned by Amire80:
Re-enable Generic.Files.LineLength and exclude failing files

Reason:
Looks like If853510b55d787765a84bac22b2dbff2e6c526c0 is the direction.

https://gerrit.wikimedia.org/r/243616

Amire80 removed subtasks: T114213: @codingStandardsIgnoreStart only works with some types of comments, T113852: @codingStandardsIgnoreStart doesn't seem to help avoid phpcs errors inside comments.Oct 5 2015, 12:42 PM

Merging https://gerrit.wikimedia.org/r/#/c/241501/ will be the last step.

T114213 is the documentation of the upstream // bug, but it's not a blocker any longer.

Anomie unsubscribed.Oct 5 2015, 2:03 PM
gerritbot added a comment.Oct 6 2015, 1:05 PM

Change 243927 had a related patch set uploaded (by Amire80):
Fix long line to make phpcs pass

https://gerrit.wikimedia.org/r/243927

gerritbot added a comment.Oct 6 2015, 1:23 PM

Change 243927 merged by jenkins-bot:
Fix long line to make phpcs pass

https://gerrit.wikimedia.org/r/243927

gerritbot added a comment.Oct 6 2015, 1:23 PM

Change 241501 merged by jenkins-bot:
Reenable LineLength phpcs check

https://gerrit.wikimedia.org/r/241501

Amire80 mentioned this in rMW695ab56c4727: Fix long line to make phpcs pass.Oct 6 2015, 1:23 PM
Amire80 closed this task as Resolved.Oct 6 2015, 1:23 PM

BANG!

And it's fixed.

No more lines over 100 characters!

Amire80 mentioned this in rMW1701d9b402c4: Reenable LineLength phpcs check.Oct 6 2015, 1:23 PM
Amire80 closed this task as Resolved.Oct 6 2015, 1:24 PM
polybuildr added a comment.Oct 6 2015, 1:24 PM

@Amire80, you are AWESOME! :D

Amire80 added a comment.Oct 6 2015, 1:42 PM

Oh you're welcome, it's just shortening some lines ;)

Thanks to @polybuildr for kicking off this process, and thanks to everybody who reviewed hundreds of modified lines!

polybuildr added a comment.Oct 6 2015, 3:00 PM
In T102614#1705435, @Amire80 wrote:

Oh you're welcome, it's just shortening some lines ;)

"some" doesn't do justice to the number. :P

I opened up just 3 patches and the counts go:
+241, -57
+60, -19
+57, -18

When I filed this task and saw the number of failures, I had assumed that all of them would probably never get fixed.

No, there's no denying it. You're AWESOME! :D

Ricordisamoa removed a project: Patch-For-Review.Oct 6 2015, 4:12 PM
matmarex awarded a token.Oct 6 2015, 8:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits