| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Create 'suppress' group and put Admin in it | mediawiki/vagrant | master | +114 -11 | |
| Grant 'flow-suppress' to the 'suppress' group as well | mediawiki/extensions/Flow | master | +1 -0 |
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Mattflaschen-WMF | T115515 Make sure mw-vagrant Flow role creates users/groups required for Flow browser tests | |||
| Resolved | • Mattflaschen-WMF | T113641 Have 'flow-suppress' work on MediaWiki-Vagrant out of the box |
Event Timeline
Comment Actions
Change 222069 had a related patch set uploaded (by Mattflaschen):
Create 'suppress' group and put Admin in it
Comment Actions
Change 240785 had a related patch set uploaded (by Mattflaschen):
Grant 'flow-suppress' to the 'suppress' group as well
Comment Actions
Change 240785 merged by jenkins-bot:
Grant 'flow-suppress' to the 'suppress' group as well
Comment Actions
(Note: I moved this comment from Grant 'flow-suppress' to the 'suppress' group as well to this task. My comment relates to the aforementioned change.)
Do we really need different user groups named 'oversight' and 'suppress'? This creates unnecessary confusion (for example, we had exactly the same name for these two groups on Finnish-language Wikipedia, until one user changed translations via Translatewiki to include specifiers in brackets; first group contains oversighters and the other group is empty). Or am I missing something, and there is a valid reason for having separate user group which has only flow-suppress right?
Comment Actions
Originally, I was going to use just 'oversight', but someone pointed out that the recommended term now is 'suppress'. See https://phabricator.wikimedia.org/diffusion/MW/browse/master/includes/DefaultSettings.php;54a50028ec6fc423c4ac1ed894f5b311463d1f15$4849 .
The goal is to replace the 'oversight' group in production with 'suppress', at which point we could drop 'oversight' from Flow too.
This comment was removed by Ejs-80.
Comment Actions
The goal is to replace the 'oversight' group in production with 'suppress', at which point we could drop 'oversight' from Flow too.
Ok, that sounds sensible. Thanks for the information.
Comment Actions
So I'm still not sure why we need two groups. Two very obvious options:
- Add flow-suppress to the oversight group, which makes the most sense. Changing it over to suppress can be done at any time.
- Change the oversight group to suppress right now and add flow-suppress to it.
Comment Actions
I can think of a couple possible ways to address the temporary duplicate group issue:
- Try to auto-detect (in wgExtensionFunctions?) which group to use.
- Just move the group settings out, so they always have to be explicitly set in LocalSettings.php/InitializeSettings.php/etc.