Page MenuHomePhabricator
Create Task
Maniphest T209036

The title "Foo" does not refer to an existing page
Closed, ResolvedPublic
Actions

Description

People complaining that when they try to edit a non-exciting page, they get fatal:

image.png (646×1 px, 199 KB)

Logstash gives this:

#0 /srv/mediawiki/php-1.33.0-wmf.3/extensions/TwoColConflict/includes/SplitTwoColConflict/SplitTwoColConflictHelper.php(196): TwoColConflict\SplitTwoColConflict\SplitTwoColConflictHelper->getRevisionRecord()
#1 /srv/mediawiki/php-1.33.0-wmf.3/extensions/TwoColConflict/includes/SplitTwoColConflict/SplitTwoColConflictHelper.php(162): TwoColConflict\SplitTwoColConflict\SplitTwoColConflictHelper->buildEditConflictView()
#2 /srv/mediawiki/php-1.33.0-wmf.3/includes/EditPage.php(2924): TwoColConflict\SplitTwoColConflict\SplitTwoColConflictHelper->getEditFormHtmlBeforeContent()
#3 /srv/mediawiki/php-1.33.0-wmf.3/includes/EditPage.php(702): EditPage->showEditForm()
#4 /srv/mediawiki/php-1.33.0-wmf.3/includes/actions/EditAction.php(60): EditPage->edit()
#5 /srv/mediawiki/php-1.33.0-wmf.3/includes/actions/SubmitAction.php(38): EditAction->show()
#6 /srv/mediawiki/php-1.33.0-wmf.3/includes/MediaWiki.php(501): SubmitAction->show()
#7 /srv/mediawiki/php-1.33.0-wmf.3/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#8 /srv/mediawiki/php-1.33.0-wmf.3/includes/MediaWiki.php(862): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.33.0-wmf.3/includes/MediaWiki.php(517): MediaWiki->main()
#10 /srv/mediawiki/php-1.33.0-wmf.3/index.php(42): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): include(string)
#12 {main}

And It's happening too often: https://logstash.wikimedia.org/goto/f9cb4383b0042c1c5d0f4c80448342e6

Details

SubjectRepoBranchLines +/-
Revert "Disable wmgUseTwoColConflict everywhere"operations/mediawiki-configmaster+1 -3
Re-enable wmgUseTwoColConflict on dewikioperations/mediawiki-configmaster+1 -0
Re-enable wmgUseTwoColConflict on group0 onlyoperations/mediawiki-configmaster+1 -0
Fix harmless edits turning into conflictsmediawiki/extensions/TwoColConflictwmf/1.33.0-wmf.3+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ladsgroup triaged this task as Unbreak Now! priority.Nov 8 2018, 10:47 AM
Ladsgroup created this task.
Restricted Application changed the subtype of this task from "Release" to "Task". · View Herald TranscriptNov 8 2018, 10:47 AM
Restricted Application added a subscriber: TerraCodes. · View Herald Transcript
Ladsgroup added a project: Two-Column-Edit-Conflict-Merge.Nov 8 2018, 10:47 AM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptNov 8 2018, 10:47 AM
gerritbot subscribed.Nov 8 2018, 10:50 AM

Change 472175 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@wmf/1.33.0-wmf.3] Fix harmless edits turning into conflicts

https://gerrit.wikimedia.org/r/472175

gerritbot added a project: Patch-For-Review.Nov 8 2018, 10:50 AM
thiemowmde mentioned this in rESCC5dddd52fcf45: Fix harmless edits turning into conflicts.Nov 8 2018, 10:54 AM
gerritbot added a comment.Nov 8 2018, 10:55 AM

Change 472411 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[operations/mediawiki-config@master] Revert "Disable wmgUseTwoColConflict everywhere"

https://gerrit.wikimedia.org/r/472411

gerritbot added a comment.Nov 8 2018, 12:23 PM

Change 472175 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@wmf/1.33.0-wmf.3] Fix harmless edits turning into conflicts

https://gerrit.wikimedia.org/r/472175

Stashbot mentioned this in T205942: Some edit submits get fatal InvalidArgumentException "The title does not refer to an existing page" from TwoColConflict extension.Nov 8 2018, 12:29 PM
Stashbot mentioned this in T208840: Monitor user reports about imaginary conflicts.
Stashbot mentioned this in T209012: Preview on a new site breaks and leads to loose of the site content.
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2018-11-08T12:29:33Z] <zfilipin@deploy1001> Synchronized php-1.33.0-wmf.3/extensions/TwoColConflict: SWAT: [[gerrit:472175|Fix harmless edits turning into conflicts (T205942 T208840 T209012 T209036)]] (duration: 00m 55s)

gerritbot added a comment.Nov 8 2018, 12:48 PM

Change 472431 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on group0 only

https://gerrit.wikimedia.org/r/472431

gerritbot added a comment.Nov 8 2018, 12:51 PM

Change 472431 merged by jenkins-bot:
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on group0 only

https://gerrit.wikimedia.org/r/472431

Stashbot added a comment.Nov 8 2018, 12:53 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-08T12:53:22Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Re-enable wmgUseTwoColConflict on group0 only T205942 T208840 T209012 T209036 (duration: 00m 54s)

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.3; 2018-11-06).Nov 8 2018, 1:01 PM
gerritbot added a comment.Nov 8 2018, 1:02 PM

Change 472434 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on dewiki

https://gerrit.wikimedia.org/r/472434

gerritbot added a comment.Nov 8 2018, 1:04 PM

Change 472434 merged by jenkins-bot:
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on dewiki

https://gerrit.wikimedia.org/r/472434

Stashbot added a comment.Nov 8 2018, 1:07 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-08T13:07:46Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Re-enable wmgUseTwoColConflict on dewiki - T205942 T208840 T209012 T209036 (duration: 00m 53s)

gerritbot added a comment.Nov 8 2018, 7:26 PM

Change 472411 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "Disable wmgUseTwoColConflict everywhere"

https://gerrit.wikimedia.org/r/472411

Stashbot added a comment.Nov 8 2018, 7:35 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-08T19:35:40Z] <thcipriani@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:472411|Revert "Disable wmgUseTwoColConflict everywhere"]] T205942 T208840 T209012 T209036 (duration: 00m 54s)

thcipriani closed this task as Resolved.Nov 8 2018, 8:18 PM
thcipriani assigned this task to thiemowmde.
thcipriani added a subscriber: thiemowmde.
In T209036#4733160, @Stashbot wrote:

Mentioned in SAL (#wikimedia-operations) [2018-11-08T19:35:40Z] <thcipriani@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:472411|Revert "Disable wmgUseTwoColConflict everywhere"]] T205942 T208840 T209012 T209036 (duration: 00m 54s)

After a re-deploy, I no longer see the errors mentioned on this task anywhere, closing train blocker and rolling forward. Thanks for the work here @thiemowmde !

greg removed a project: Release-Engineering-Team (Kanban).Nov 8 2018, 10:06 PM
Liuxinyu970226 unsubscribed.Nov 11 2018, 6:46 AM
RandomDSdevel awarded a token.Nov 13 2018, 2:35 AM
Tobi_WMDE_SW mentioned this in T210591: Create incident report for the get-editconflict-everywhere issue.Nov 28 2018, 9:55 AM
Ladsgroup removed a project: Patch-For-Review.May 21 2019, 9:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits