Page MenuHomePhabricator
Create Task
Maniphest T242146

Special:LinkSearch listed in wrong section on Special:SpecialPages
Closed, ResolvedPublic
Actions

Description

https://abj.miraheze.org/wiki/Special:SpecialPages says

Redirecting special pages

• External links search

However nowadays it no longer redirects,

$ HEAD -SU https://abj.miraheze.org/wiki/Special:LinkSearch
HEAD https://abj.miraheze.org/wiki/Special:LinkSearch
User-Agent: lwp-request/6.43 libwww-perl/6.43

200 OK

Thus it is placed in the wrong section there on Special:SpecialPages.

Details

SubjectRepoBranchLines +/-
Move Special:LinkSearch to pages groupmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Jidanni created this task.Jan 7 2020, 6:42 PM
Restricted Application added a project: User-RhinosF1. · View Herald TranscriptJan 7 2020, 6:42 PM
Restricted Application added subscribers: RhinosF1, Aklapper. · View Herald Transcript
RhinosF1 moved this task from To triage to Special:LinkSearch on the MediaWiki-Special-pages board.Jan 7 2020, 6:43 PM
RhinosF1 moved this task from Radar to Miraheze-Related Issues (not reported there) on the User-RhinosF1 board.
DannyS712 claimed this task.Jan 7 2020, 6:55 PM
DannyS712 subscribed.

Moving to pagetools

Restricted Application added a project: User-DannyS712. · View Herald TranscriptJan 7 2020, 6:55 PM
gerritbot added a comment.Jan 7 2020, 6:56 PM

Change 562580 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Move Special:LinkSearch to pagetools group

https://gerrit.wikimedia.org/r/562580

gerritbot added a project: Patch-For-Review.Jan 7 2020, 6:56 PM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Jan 7 2020, 6:57 PM
RhinosF1 removed a project: Patch-For-Review.Jan 7 2020, 8:50 PM
In T242146#5783339, @gerritbot wrote:

Change 562580 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Move Special:LinkSearch to pagetools group

https://gerrit.wikimedia.org/r/562580

+1

RhinosF1 added a project: Patch-For-Review.Jan 7 2020, 8:50 PM
Legoktm added subscribers: siebrand, Legoktm.Jan 9 2020, 7:16 AM
In T242146#5783334, @DannyS712 wrote:

Moving to pagetools

LinkSearch was originally in redirects because of T16865: Search and Linksearch special pages belong in one group - to match Special:Search (done in r39138 by @siebrand, when it was still an extension).

In 505dbb331e1, Special:Search was moved into pages, because having it in redirects didn't make sense to @siebrand (It doesn't make sense to me either).

I agree with both of those rationales, and think that we should be moving Special:LinkSearch into pages to match Special:Search.

DannyS712 added a comment.Jan 9 2020, 7:20 AM
In T242146#5788916, @Legoktm wrote:
In T242146#5783334, @DannyS712 wrote:

Moving to pagetools

LinkSearch was originally in redirects because of T16865: Search and Linksearch special pages belong in one group - to match Special:Search (done in r39138 by @siebrand, when it was still an extension).

In 505dbb331e1, Special:Search was moved into pages, because having it in redirects didn't make sense to @siebrand (It doesn't make sense to me either).

I agree with both of those rationales, and think that we should be moving Special:LinkSearch into pages to match Special:Search.

{{done}} in patch set 3

RhinosF1 added a comment.Jan 9 2020, 7:25 AM

Sounds good

gerritbot added a comment.Jan 9 2020, 10:14 AM

Change 562580 merged by jenkins-bot:
[mediawiki/core@master] Move Special:LinkSearch to pages group

https://gerrit.wikimedia.org/r/562580

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Jan 9 2020, 11:00 AM
RhinosF1 added a comment.Jan 9 2020, 3:08 PM

This should be resolved with next train. Is it worth backporting?

DannyS712 edited projects, added User-notice; removed Patch-For-Review.Jan 9 2020, 6:12 PM
In T242146#5789793, @RhinosF1 wrote:

This should be resolved with next train. Is it worth backporting?

Not warranted, though it could be mentioned in tech news

DannyS712 moved this task from To Triage to Announce in next Tech/News on the User-notice board.Jan 9 2020, 6:13 PM
DannyS712 closed this task as Resolved.Jan 10 2020, 2:58 AM
DannyS712 moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.

Added to tech news, see https://meta.wikimedia.org/w/index.php?title=Tech/News/2020/03&diff=19693618&oldid=19692772

DannyS712 moved this task from Awaiting review and deployment to Merged on the User-DannyS712 board.Jan 13 2020, 12:54 AM
Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Jan 16 2020, 5:03 AM
RhinosF1 moved this task from Miraheze-Related Issues (not reported there) to Done on the User-RhinosF1 board.Mar 3 2020, 10:38 PM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:44 PM
Restricted Application added a subscriber: Reception123. · View Herald TranscriptAug 13 2022, 1:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits