Page MenuHomePhabricator
Create Task
Maniphest T265897

Create implicit use of description in content language
Closed, ResolvedPublic
Actions

Description

See parent task for details

Details

SubjectRepoBranchLines +/-
Add implicit usage on description in content languagemediawiki/extensions/Wikibasemaster+685 -4
Fix keys in ImplicitDescriptionUsageLookup::getUsagesForPagemediawiki/extensions/Wikibasemaster+15 -17
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedLydia_PintscherT191831 Track implicit use of non-overridden wikidata description
ResolvedLucas_Werkmeister_WMDET265897 Create implicit use of description in content language
· · ·

Event Timeline

Lucas_Werkmeister_WMDE created this task.Oct 19 2020, 12:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2020, 12:56 PM
Lucas_Werkmeister_WMDE mentioned this in T191831: Track implicit use of non-overridden wikidata description.Oct 19 2020, 12:56 PM
ItamarWMDE subscribed.Oct 20 2020, 6:33 AM

Is there a description to this task?

• Pablo-WMDE updated the task description. (Show Details)Oct 20 2020, 6:51 AM
Lucas_Werkmeister_WMDE claimed this task.Oct 20 2020, 1:16 PM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lucas_Werkmeister_WMDE added a subscriber: Lydia_Pintscher.Oct 20 2020, 2:51 PM

@Lydia_Pintscher is it okay if the description usage shows up in the page information (action=info) just like a real usage?

Screenshot_2020-10-20 Information for Main Page - wiki2.png (133×448 px, 11 KB)

gerritbot added a comment.Oct 20 2020, 3:07 PM

Change 635310 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Add implicit usage on description in content language

https://gerrit.wikimedia.org/r/635310

gerritbot added a project: Patch-For-Review.Oct 20 2020, 3:07 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 20 2020, 5:25 PM
Lucas_Werkmeister_WMDE added a comment.Oct 21 2020, 10:10 AM
In T265897#6564585, @Lucas_Werkmeister_WMDE wrote:

@Lydia_Pintscher is it okay if the description usage shows up in the page information (action=info) just like a real usage?

Screenshot_2020-10-20 Information for Main Page - wiki2.png (133×448 px, 11 KB)

Answered elsewhere: yes, that’s okay.

Note that the implementation in my current change will also cause the client page to be rerendered (purged) if the description changes, because the part that determines which pages need purging also sees it as a usage like any other.

Lucas_Werkmeister_WMDE mentioned this in T266499: Optimize ChangeHandler and AffectedPagesFinder.Oct 26 2020, 6:30 PM
• toan subscribed.EditedOct 28 2020, 10:46 AM

I tried this out locally and it seems to do what we want so I've +2ed both patches! Should we move this back to "todo" to enable the setting and try it out on the test system?

gerritbot added a comment.Oct 28 2020, 11:15 AM

Change 635310 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add implicit usage on description in content language

https://gerrit.wikimedia.org/r/635310

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 28 2020, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 28 2020, 12:10 PM
• toan added a comment.Oct 28 2020, 12:50 PM

Moving this back to TODO as we should now enable and test it.

• toan removed Lucas_Werkmeister_WMDE as the assignee of this task.Oct 28 2020, 12:51 PM
• toan moved this task from Peer Review to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Oct 28 2020, 2:56 PM

Change 636938 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix keys in ImplicitDescriptionUsageLookup::getUsagesForPage

https://gerrit.wikimedia.org/r/636938

gerritbot added a project: Patch-For-Review.Oct 28 2020, 2:56 PM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 28 2020, 2:58 PM
gerritbot added a comment.Oct 29 2020, 10:15 AM

Change 636938 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix keys in ImplicitDescriptionUsageLookup::getUsagesForPage

https://gerrit.wikimedia.org/r/636938

• toan moved this task from Peer Review to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 29 2020, 10:21 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 29 2020, 11:10 AM
Lucas_Werkmeister_WMDE closed this task as Resolved.Nov 11 2020, 4:29 PM
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
In T265897#6584567, @toan wrote:

Moving this back to TODO as we should now enable and test it.

I created T267745: Enable implicit description use in production for that, I think it’s better to mark this task as done.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Nov 11 2020, 5:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits