MobileFrontend sets a property on OutputPage unstyledContent for all mobile special pages, it provides. This is read by Minerva when deciding how to output the special page. We'd like to avoid this confusing communication between MobileFrontend and Minerva. The directive, tells Minerva to turn off the content class for all special pages provided inside MobileFrontend. This is likely better served by skinStyles for those particular special pages.
TODO
- Update minerva.mustache to use template variables provided by core (https://www.mediawiki.org/wiki/Manual:SkinMustache.php#Template_data). Remove the usage of unstyledContent.
- Add skin styles to apply to the relevant special pages which are impacted by unstyledContent (see QA steps).
- MinervaTemplate::getContentHtml should be removed
- Drop contenthtml from SkinMinerva::getTemplateData
- Remove the setting of unstyledContent in SkinMinerva::prepareQuickTemplate
- Drop code in MobileFrontend setting unstyledContent
QA
Resize browser to mobile (320px), tablet (720px) and desktop (1000px) thresholds for each of these pages on the mobile domain with AMC disabled. When testing we are looking specifically for problems with how the content is aligned horizontally:
- Check Special:RecentChanges for UI regressions e.g. https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges
- Check Special:Nearby for UI regressions (not Extension:Nearby version)
- Check mobile diff page for UI regressions e.g. Special:MobileDiff e.g. https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:MobileDiff/310553&type=revision
- Check Special:MobileLanguages for UI regressions
- Check Special:MobileContributions for UI regressions
- Check Special:MobileWAtchlist for UI regressions
- Check mobile history page for UI regressions e.g. https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Caption_list&action=history
With AMC enabled check the following:
- Check Special:MobileContributions for UI regressions
- Check Special:MobileWAtchlist for UI regressions
- Check mobile history page for UI regressions e.g. https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Caption_list&action=history
https://phabricator.wikimedia.org/T291871#7504783
QA Results - Beta
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T291871#7504780 |
| 2 | ✅ | T291871#7504780 |
| 3 | ✅ | T291871#7504780 |
| 4 | ✅ | T291871#7504780 |
| 5 | ✅ | T291871#7504780 |
| 6 | ❌ | T291871#7504780 |
| 7 | ✅ | T291871#7504780 |
| 8 | ✅ | T291871#7504780 |
| 9 | ✅ | T291871#7504780 |
| 10 | ✅ | T291871#7504780 |
QA Results -Prod
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T291871#7504783 |
| 2 | ✅ | T291871#7504783 |
| 3 | ✅ | T291871#7504783 |
| 4 | ✅ | T291871#7504783 |
| 5 | ✅ | T291871#7504783 |
| 6 | ||
| 7 | ✅ | T291871#7504783 |
| 8 | ✅ | T291871#7504783 |
| 9 | ✅ | T291871#7504783 |
| 10 | ✅ | T291871#7504783 |