Page MenuHomePhabricator

ExtensionRegistry must not be instantiated in extensions
Open, Needs TriagePublic

Description

ExtensionRegistry is not @newable. Extensions must not call new ExtensionRegistry.

There's 1 deployed violation now:

  • extensions / Flow

There's 2 non-deployed violations:

  • extensions / MediaWikiFarm
  • extensions / SocialProfile

Event Timeline

As for the SocialProfile one, it was added in 0d8addf5af4be90fb18a34aac849157441e74187 due to T243861 to get CI working again. It's only ever hit when defined( 'MEDIAWIKI_INSTALL' ) evaluates to true. Perhaps @Jdforrester-WMF can comment more as the +2-er of the aforementioned patch, but I doubt that this is an urgent matter.

As for the SocialProfile one, it was added in 0d8addf5af4be90fb18a34aac849157441e74187 due to T243861 to get CI working again. It's only ever hit when defined( 'MEDIAWIKI_INSTALL' ) evaluates to true. Perhaps @Jdforrester-WMF can comment more as the +2-er of the aforementioned patch, but I doubt that this is an urgent matter.

Oh gosh yes, that patch. What a mess. I assumed that was only a temporary hack to make things work again ahead of migration to extension.json for the top-level repo itself, but I see that that's not (yet) happened. Once that's done it's likely not going to be needed any more, I suspect?