Page MenuHomePhabricator
Create Task
Maniphest T295920

Add an image: quality gate is no longer applied (regression)
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Betalabs w/imagerecommendation variant
  • Go to Special:Homepage
  • Click on task card on desktop

What happens?:
I was able to proceed to the article. There is a console error:

load.php?lang=en&modules=ext.growthExperiments.Homepage.SuggestedEdits|jquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=vector&version=17wjj:64 Uncaught TypeError: Cannot read properties of undefined (reading 'mobileOnly')
    at QualityGate.checkMobileOnlyGate (load.php?lang=en&modules=ext.growthExperiments.Homepage.SuggestedEdits|jquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=vector&version=17wjj:64)
    at QualityGate.<anonymous> (load.php?lang=en&modules=ext.growthExperiments.Homepage.SuggestedEdits|jquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=vector&version=17wjj:64)
    at QualityGate.<anonymous> (load.php?lang=en&modules=ext.growthExperiments.Homepage.SuggestedEdits|jquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=vector&version=17wjj:64)
    at Array.every (<anonymous>)
    at QualityGate.checkAll (load.php?lang=en&modules=ext.growthExperiments.Homepage.SuggestedEdits|jquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=vector&version=17wjj:64)
    at SuggestedEditsModule.<anonymous> (load.php?lang=en&modules=ext.growthExperiments.Homepage.SuggestedEdits|jquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=vector&version=17wjj:18)
    at HTMLDivElement.dispatch (load.php?lang=en&modules=ext.growthExperiments.Homepage.SuggestedEdits|jquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=vector&version=17wjj:168)
    at HTMLDivElement.elemData.handle (load.php?lang=en&modules=ext.growthExperiments.Homepage.SuggestedEdits|jquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=vector&version=17wjj:164)

What should have happened instead?:
A dialog should be shown.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
1.38.0-alpha (a2b9593)

Details

SubjectRepoBranchLines +/-
Structured tasks: Caching/filtering related improvementsmediawiki/extensions/GrowthExperimentsmaster+91 -44
Set qualityGateConfig when filtering link recommendation tasksmediawiki/extensions/GrowthExperimentsmaster+3 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• mewoph created this task.Nov 17 2021, 7:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 17 2021, 7:33 PM
• mewoph triaged this task as High priority.Nov 17 2021, 7:33 PM
• mewoph added a project: Growth-Team (Sprint 0 (Growth Team)).
• mewoph claimed this task.Nov 17 2021, 7:50 PM
• mewoph moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Nov 17 2021, 7:53 PM

Change 739613 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Set qualityGateConfig when filtering link recommendation tasks

https://gerrit.wikimedia.org/r/739613

gerritbot added a project: Patch-For-Review.Nov 17 2021, 7:53 PM
• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 17 2021, 7:53 PM
• mewoph added a parent task: T285587: [EPIC] "Add an image" Iteration 1.
MMiller_WMF subscribed.Nov 17 2021, 8:45 PM

We would like to backport this so that it can be included in ambassador testing, which starts on Friday, and so that their communities can see it in action if more people test out "add an image".

• mewoph added a comment.Nov 17 2021, 9:57 PM

This is caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/722593 which is in MW-1.38-notes (1.38.0-wmf.11; 2021-11-30). We may not need to backport if the patch gets merged into the same milestone.

Aklapper removed a subscriber: Growth-Team (Sprint 0 (Growth Team)).Nov 18 2021, 10:56 AM
gerritbot added a comment.Nov 19 2021, 11:26 AM

Change 740110 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] Structured tasks: Caching/filtering related improvements

https://gerrit.wikimedia.org/r/740110

gerritbot added a comment.Nov 19 2021, 6:30 PM

Change 739613 abandoned by MewOphaswongse:

[mediawiki/extensions/GrowthExperiments@master] Set qualityGateConfig when filtering link recommendation tasks

Reason:

In favor of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/740110

https://gerrit.wikimedia.org/r/739613

gerritbot added a comment.Nov 22 2021, 1:42 AM

Change 740110 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Structured tasks: Caching/filtering related improvements

https://gerrit.wikimedia.org/r/740110

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 22 2021, 2:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 22 2021, 2:10 AM
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 22 2021, 11:14 PM
Etonkovidova closed this task as Resolved.Nov 24 2021, 11:13 PM
Etonkovidova subscribed.

Checked in betalabs and wmf.9 - the warning dialog to users is displayed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits