Page MenuHomePhabricator

🏷️📜 Don't resolve redirects when validating a label or description edit request
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue

  • create an item redirect
  • make a request to the redirected item that would either result in its redirect target to have the same label and description
  • OR make a request to the redirected item that would cause its redirect target to have the same label and description as another item (collision)

What happens?:

  • the API responds with a 400 label-description-same-value or item-label-description-duplicate

What should have happened instead?:

  • the API responds with a 409 redirected-item

Technical note:

  • We probably don't want WikibaseEntityLookupItemDataRetriever to resolve redirects. Making it return null in case of a redirect would likely result in the expected behavior.

Event Timeline

Change 914354 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Don't resolve redirects in ItemDataRetrievers

https://gerrit.wikimedia.org/r/914354

Change 914354 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Don't resolve redirects in ItemDataRetrievers

https://gerrit.wikimedia.org/r/914354