Maniphest T336024

Remove isBatchProcessor from DonationInterface
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Ejegg
	May 5 2023, 2:40 AM

Tags

Referenced Files

None

Subscribers

Description

isBatchProcessor was used to indicate whether a gateway adapter class was being used to render a front-end form or to perform a back-end process like orphan slaying or recurring charges. Now that we are no longer using gateway adapters outside of the front-end form we should take it away and remove some confusion.

Details

	Subject	Repo	Branch	Lines +/-
	Get rid of the rest of batch processor code	mediawiki/extensions/DonationInterface	master	+10 -80
	Delete 'isBatchProcessor' in extras	mediawiki/extensions/DonationInterface	master	+14 -21
	Stop using batch_mode in tests	mediawiki/extensions/DonationInterface	master	+7 -36
	Stop using batch_mode in tests	mediawiki/extensions/DonationInterface	master	+17 -34
	Delete unreachable code	mediawiki/extensions/DonationInterface	master	+10 -35

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T291697 [Epic] Architecture, separation of concerns and refactors in DonationInterface and SmashPig (2021)
		Resolved		None	T336024 Remove isBatchProcessor from DonationInterface

Event Timeline

Ejegg created this task.May 5 2023, 2:40 AM

AKanji-WMF moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.May 8 2023, 7:40 PM

AKanji-WMF moved this task from Sprint +1 to Later on the Fundraising-Backlog board.

Change 934374 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Stop using batch_mode in tests

https://gerrit.wikimedia.org/r/934374

gerritbot added a project: Patch-For-Review.Jun 29 2023, 3:50 PM

Change 992216 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Delete unreachable code

https://gerrit.wikimedia.org/r/992216

AKanji-WMF added a project: fundraising near future temp.Feb 6 2024, 7:20 PM

AKanji-WMF removed a project: fundraising near future temp.Feb 6 2024, 8:13 PM

Change 992216 abandoned by Ejegg:

[mediawiki/extensions/DonationInterface@master] Delete unreachable code

Reason:

https://gerrit.wikimedia.org/r/992216

Change #1035821 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Delete 'isBatchProcessor' in extras

https://gerrit.wikimedia.org/r/1035821

Change #934374 abandoned by Ejegg:

[mediawiki/extensions/DonationInterface@master] Stop using batch_mode in tests

Reason:

https://gerrit.wikimedia.org/r/934374

Change #1035823 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Stop using batch_mode in tests

https://gerrit.wikimedia.org/r/1035823

Change #1035824 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Get rid of the rest of batch processor code

https://gerrit.wikimedia.org/r/1035824

Ejegg added a project: Fundraising Sprint: justWork().May 24 2024, 9:05 PM

Ejegg moved this task from Later to Current Sprint on the Fundraising-Backlog board.

Ejegg moved this task from Backlog to Ready for Review on the Fundraising Sprint: justWork() board.

Change #1035821 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Delete 'isBatchProcessor' in extras

https://gerrit.wikimedia.org/r/1035821

Change #1035823 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Stop using batch_mode in tests

https://gerrit.wikimedia.org/r/1035823

Change #1035824 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Get rid of the rest of batch processor code

https://gerrit.wikimedia.org/r/1035824

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.8; 2024-06-04).May 31 2024, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 31 2024, 12:30 PM

Ejegg moved this task from Ready for Review to Done on the Fundraising Sprint: justWork() board.May 31 2024, 2:19 PM

XenoRyet closed this task as Resolved.Jun 3 2024, 7:15 PM

XenoRyet set Final Story Points to 2.