Page MenuHomePhabricator
Create Task
Maniphest T354539

Help field from TOTPAuthenticationRequest isn't actually shown...
Closed, ResolvedPublic
Actions

Description

Screenshot 2024-01-08 at 16.48.16.png (362×376 px, 18 KB)

vs

	/**
	 * @return array
	 */
	public function getFieldInfo() {
		return [
			'OATHToken' => [
				'type' => 'string',
				'label' => wfMessage( 'oathauth-auth-token-label' ),
				'help' => wfMessage( 'oathauth-auth-token-help' )
			]
		];
	}

This isn't helpful...

See T189924#9442403 for a comparison of how/where it shows on other fields...

Details

SubjectRepoBranchLines +/-
Display help on OATHToken fieldmediawiki/extensions/OATHAuthREL1_43+3 -0
Display help on OATHToken fieldmediawiki/extensions/OATHAuthREL1_42+3 -0
Display help on OATHToken fieldmediawiki/extensions/OATHAuthREL1_41+3 -0
Display help on OATHToken fieldmediawiki/extensions/OATHAuthREL1_39+3 -0
Display help on OATHToken fieldmediawiki/extensions/OATHAuthmaster+3 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Jan 8 2024, 4:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 8 2024, 4:48 PM
Reedy updated the task description. (Show Details)Jan 8 2024, 4:49 PM
Reedy added a project: MediaWiki-Core-AuthManager.
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptJan 8 2024, 4:51 PM
Reedy removed projects: MediaWiki-Core-AuthManager, MediaWiki-Platform-Team.Jan 8 2024, 5:08 PM
Reedy added a subtask: T354541: AuthenticationRequest don't show help fields on forms.
Reedy moved this task from Backlog to User Experience on the MediaWiki-extensions-OATHAuth board.Jan 8 2024, 6:58 PM
Tgr closed subtask T354541: AuthenticationRequest don't show help fields on forms as Resolved.Jan 22 2024, 11:01 PM
gerritbot added a comment.Sat, Nov 2, 3:13 PM

Change #1085981 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] Display help on OATHToken field

https://gerrit.wikimedia.org/r/1085981

gerritbot added a project: Patch-For-Review.Sat, Nov 2, 3:13 PM
gerritbot added a comment.Sat, Nov 2, 4:01 PM

Change #1085981 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] Display help on OATHToken field

https://gerrit.wikimedia.org/r/1085981

Reedy closed this task as Resolved.Sat, Nov 2, 4:02 PM
Reedy claimed this task.
gerritbot added a comment.Sat, Nov 2, 4:02 PM

Change #1085992 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@REL1_43] Display help on OATHToken field

https://gerrit.wikimedia.org/r/1085992

gerritbot added a comment.Sat, Nov 2, 4:02 PM

Change #1085993 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@REL1_42] Display help on OATHToken field

https://gerrit.wikimedia.org/r/1085993

gerritbot added a comment.Sat, Nov 2, 4:02 PM

Change #1085994 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@REL1_41] Display help on OATHToken field

https://gerrit.wikimedia.org/r/1085994

gerritbot added a comment.Sat, Nov 2, 4:03 PM

Change #1085995 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@REL1_39] Display help on OATHToken field

https://gerrit.wikimedia.org/r/1085995

gerritbot added a comment.Sat, Nov 2, 4:08 PM

Change #1085995 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_39] Display help on OATHToken field

https://gerrit.wikimedia.org/r/1085995

gerritbot added a comment.Sat, Nov 2, 4:10 PM

Change #1085994 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_41] Display help on OATHToken field

https://gerrit.wikimedia.org/r/1085994

gerritbot added a comment.Sat, Nov 2, 4:12 PM

Change #1085993 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_42] Display help on OATHToken field

https://gerrit.wikimedia.org/r/1085993

gerritbot added a comment.Sat, Nov 2, 4:14 PM

Change #1085992 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_43] Display help on OATHToken field

https://gerrit.wikimedia.org/r/1085992

Maintenance_bot removed a project: Patch-For-Review.Sat, Nov 2, 4:31 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.2; 2024-11-05).Sat, Nov 2, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits