Page MenuHomePhabricator

🎯 [Format/Rewrite] patch-target-not-found
Closed, ResolvedPublic5 Estimated Story Points

Description

Acceptance criteria:

  • Error code: patch-target-not-found
  • New message: "Target not found on resource"
  • Context: { "path": "{json_pointer_to_target_in_patch}" } (e.g. { "path": "/patch/2/path" }, { "path": "/patch/3/from" })
  • HTTP status code: 409

Event Timeline

WMDE-leszek set the point value for this task to 5.
Muhammad_Yasser_Jazirahly_WMDE renamed this task from [Format/Rewrite] patch-target-not-found to 🎯 [Format/Rewrite] patch-target-not-found.Jun 25 2024, 2:18 PM
Jakob_WMDE subscribed.

Since the upstream change was merged an published, this now requires:

Wikibase patch:

  • update the OpenAPI doc
  • bumping the version of json-diff to the latest one in composer.json
  • in repo/rest-api/src/Application/UseCases/PatchJson.php, change the UseCaseError accordingly
  • adjust e2e tests

Change #1051356 had a related patch set uploaded (by Dima koushha; author: Dima koushha):

[mediawiki/vendor@master] Bump swaggest/json-diff to 3.11.0

https://gerrit.wikimedia.org/r/1051356

Change #1051386 had a related patch set uploaded (by Dima koushha; author: Dima koushha):

[mediawiki/extensions/Wikibase@master] REST: Bump swaggest/json-diff to 3.11.0

https://gerrit.wikimedia.org/r/1051386

Change #1051389 had a related patch set uploaded (by Dima koushha; author: Dima koushha):

[mediawiki/extensions/Wikibase@master] REST: Format/rewrite patch-target-not-found error

https://gerrit.wikimedia.org/r/1051389

Change #1051356 merged by jenkins-bot:

[mediawiki/vendor@master] Bump swaggest/json-diff to 3.11.0

https://gerrit.wikimedia.org/r/1051356

Change #1051386 abandoned by Dima koushha:

[mediawiki/extensions/Wikibase@master] REST: Bump swaggest/json-diff to 3.11.0

Reason:

https://gerrit.wikimedia.org/r/1051386

Change #1051389 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Format/rewrite patch-target-not-found error

https://gerrit.wikimedia.org/r/1051389