@matmarex @TheDJ I think this may have been caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1088731 (T177251) ?

Maybe related, I've just noticed that I'm getting a load of Uncaught InternalError: too much recursion console errors when searching (Vector 2010) and using arrow keys to navigate the search results is not working as expected (gif below, I am just pressing the down arrow):

Uncaught InternalError: too much recursion
    jQuery 7
jquery.js:2396:19
    jQuery 18
    <anonymous> searchSuggest.js:372
    jQuery 17
    <anonymous> searchSuggest.js:372
    jQuery 17
    <anonymous> searchSuggest.js:372
    jQuery 17
    <anonymous> searchSuggest.js:372
    jQuery 17
    <anonymous> searchSuggest.js:372
    jQuery 17
    <anonymous> searchSuggest.js:372
    jQuery 17
    <anonymous> searchSuggest.js:372
    dispatch jQuery

Yep that matches the errors I'm seeing in logstash. @TheresNoTime are you able to update the description with replication steps? Can you replicate the issue locally (and if so can you fix it by reverting https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1088731 ?)

In T379983#10324858, @Jdlrobson wrote:

Yep that matches the errors I'm seeing in logstash. @TheresNoTime are you able to update the description with replication steps? Can you replicate the issue locally (and if so can you fix it by reverting https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1088731 ?)

(sorry, I've stepped away from the computer now — but fwiw given $( this ).trigger( 'keypress' ); looks like it'll trigger a change and/or input event, and thus the recursion, I'd agree that's the cause)

nb. created a revert (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1091470) and then made a patchdemo using that patch — issue is reproducible on a patchdemo running latest core (e.g. https://167789d4d8.catalyst.wmcloud.org/w/), but not once that change is reverted.

Revert patch: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1091470 merged. (I just realized it wasn't tagged with this task, oops.)

I've made a backport patch — I'm around to do this today if needed, but given it's a Friday can it wait until Monday?

Thanks @matmarex and @TheresNoTime for confirming the fix. I think it's okay for this to wait until Monday.

I don't think it's impacting end users (please correct me if I'm wrong?), it's just triggering alerts on our monitoring.

It is affecting end users, unless this is unrelated:

In T379983#10324771, @TheresNoTime wrote:

searching (Vector 2010) and using arrow keys to navigate the search results is not working as expected (gif below, I am just pressing the down arrow):

Made it impossible to use keyboard navigation in search. Please don't wait till Monday. Vector 2010 is still the default skin in multiple projects, too.

This is certainly still an issue in vector-2010, able to reproduce and still getting user stories raised in VRT.

Change #1091605 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Samtar):

[mediawiki/core@wmf/1.44.0-wmf.3] Revert "Allow other input and changes to trigger searchsuggestions to update"

https://gerrit.wikimedia.org/r/1091605

Change #1091605 merged by jenkins-bot:

[mediawiki/core@wmf/1.44.0-wmf.3] Revert "Allow other input and changes to trigger searchsuggestions to update"

https://gerrit.wikimedia.org/r/1091605

Mentioned in SAL (#wikimedia-operations) [2024-11-18T15:03:30Z] <lucaswerkmeister-wmde@deploy2002> Started scap sync-world: Backport for [[gerrit:1091605|Revert "Allow other input and changes to trigger searchsuggestions to update" (T379983)]]

Mentioned in SAL (#wikimedia-operations) [2024-11-18T15:06:38Z] <lucaswerkmeister-wmde@deploy2002> samtar, lucaswerkmeister-wmde: Backport for [[gerrit:1091605|Revert "Allow other input and changes to trigger searchsuggestions to update" (T379983)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-11-18T15:11:45Z] <lucaswerkmeister-wmde@deploy2002> Finished scap sync-world: Backport for [[gerrit:1091605|Revert "Allow other input and changes to trigger searchsuggestions to update" (T379983)]] (duration: 08m 14s)