Proposed code changes authored by contributors outside of the Platform Engineering team
Details
Jul 25 2024
@matmarex would you mind taking a look at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1055617 which is where I envision this going next - should that patch be split up into multiple smaller steps? Or does it work as a single patch?
Jul 24 2024
Change #1055582 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate public access to EditPage::internalAttemptSave()
Jul 21 2024
Change #1055617 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/core@master] DRAFT: EditPage internalAttemptSaveToConstraint()
Change #1055584 merged by jenkins-bot:
[mediawiki/core@master] EditFilterMergedContentHookConstraint: fix docs typo
Change #1055584 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/core@master] EditFilterMergedContentHookConstraint: fix docs typo
Change #1055582 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/core@master] Hard deprecate public access to EditPage::internalAttemptSave()
Jul 15 2024
Change #1053993 merged by jenkins-bot:
[mediawiki/core@master] Move section-check logic to ExistingSectionEditConstraint
Change #1053992 merged by jenkins-bot:
[mediawiki/core@master] Move AS_REVISION_WAS_DELETED handling into constraint
Change #1053989 merged by jenkins-bot:
[mediawiki/core@master] Rename AutoSummaryMissingSummaryConstraint
Same here. That said, I think I've been able to stay on top of code review requests recently, so I should be able to keep up with you as well. Thanks for working on it :)
Jul 13 2024
Jul 12 2024
Change #1053993 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/core@master] Move section-check logic to ExistingSectionEditConstraint
Change #1053992 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/core@master] Move AS_REVISION_WAS_DELETED handling into constraint
Change #1053989 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/core@master] Rename AutoSummaryMissingSummaryConstraint
Change #1053782 merged by jenkins-bot:
[mediawiki/core@master] EditPage::internalAttemptSave() - move more logic to constraints
Jul 11 2024
Okay, so coming back to this after a *while*, I'm going to try to make some more progress
- some more logic can be moved to constraints (first patch for that already sent ^)
- internalAttemptSave() isn't called anywhere in core or deployed extensions outside of EditPage.php and tests, so we can make it private (with a changed name) and replace the public version with a hard deprecated wrapper for the private one - after the hard deprecation, we can remove the public-ness of the method, and then refactoring the interface will be a lot simpler
- the biggest part of this will still be blocked by T251588, which hasn't had any progress - can I convince one of the subscribers or teams watching to take that up? I'm happy to provide code review
Change #1053782 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/core@master] EditPage::internalAttemptSave() - move more logic to constraints
Jul 4 2024
Jul 1 2024
Jun 16 2024
Change #935486 had a related patch set uploaded (by TheDJ; author: TheDJ):
[mediawiki/core@master] Searchindex primary key, InnoDB engine and title length
Jun 2 2024
May 29 2024
May 14 2024
Apr 23 2024
Change #1023063 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Use EmailUser class for permission checking
Apr 22 2024
Change #1023063 had a related patch set uploaded (by Majavah; author: Majavah):
[mediawiki/extensions/CampaignEvents@master] Use EmailUser class for permission checking
Apr 15 2024
This epic will continue in T343020: Converting MediaWiki Metrics to StatsLib
Apr 4 2024
Apr 3 2024
Mar 28 2024
Feb 27 2024
Seeing that even if the current behavior is annoying for me it seems that nobody else cares, so I'm removing myself as the assignee. Even if the problems of the patch were addressed a long time ago no one wanted to +2 at the moment and it doesn't annoy me enough to try to find someone who would be willing to +2 now. I don't know if I should abandon the patch or leave it as is, feel free to do whatever.
Feb 12 2024
Change 753522 abandoned by Kosta Harlan:
[mediawiki/core@master] [WIP] Run saveOptionsInternal in DeferredUpdate
Reason: