In D234676#9662062, @nchevobbe wrote:

Karan I can't pull the patch.
Can you update your repo, rebase your patch and push again please? Thanks

In D268707#9662065, @nchevobbe wrote:

(patch needs to be rebased)

I have fixed most of the issues but not able to run the tests on my system, is there any other way to run the tests.
One more thing, I have also done the rebase.

I have updated both the revision (test + component).

Now I have updated the test covering all the cases, let me know if there's any issue.

In D235604#8230359, @nchevobbe wrote:

It also looks like we're making a couple test to fail:

• devtools/client/jsonview/test/browser_jsonview_filter.js which is expected, since we're not filtering anymore
• devtools/client/accessibility/test/browser/browser_accessibility.js
• devtools/client/dom/test/browser_dom_array.js

not sure what's going on for the last 2, but we should look into it

I have added the test, let me know if I am missing something in the test.
https://phabricator.services.mozilla.com/D268707

Now, I have pulled the new changes. Let me know if there's any issue.
Working on test(s).

This looks good to me, let me know if there's any issue.

Updated the patch, working on test now.

In D233332#8180970, @nchevobbe wrote:

There are some issues that need to be addressed: https://treeherder.mozilla.org/jobs?repo=try&revision=80b81b14e9af22945d72d971c33d0027860c91f7&selectedTaskRun=CLHYW_lyR8mKYeWP3gFfSA.0

LGTM, let me know if there are any other issues.

Ok sir, I'll fix these issues.

Updated the patch, let me know if there's any issue in this revision.

I have updated the patch, let me know if there's any issue in this revision.
@nchevobbe help: as I have changed onFilter to onSearch and TreeView is generic component, so there might be some issue elsewhere it is used. I have fixed it in most of the places, but I am not confident about that.

In D234676#8143561, @nchevobbe wrote:
nitpick: If you open this URL in a tab data:application/json,{"test":{"small":12,"big": 1516340399466235648, "precise": 3.141592653589793238462643383279, "negzero": -0,"zero": 0, "exp": 1e2}}, and then select any of the node which has the JS badge, the breadcrumb icon will be the one for an object, not for a number. There was some changes in https://bugzilla.mozilla.org/show_bug.cgi?id=1431808 and we should take that into consideration

I am highlighting the complete row, let me know if there's any issue.

question
suppose there is too much nesting in JSON data then the breadcrumbs will overflow and scrollbar is shown is that okay.

I have updated the patch and test is in progress. If there's any issue in this revision, let me know.

Let me know if there's any issue.

Updated and rebased the patch.
Let me know if there's any issue in this diff.

In D233332#8099991, @nchevobbe wrote:

Also, can you pull the latest change in your repo and rebase your patch? Thanks!

Reason

Let me know if there's any issue in this test

Updated the patch
test
https://phabricator.services.mozilla.com/D234065

Updated the patch, let me know if there's any issue.

Review the change here:
https://phabricator.services.mozilla.com/D233339

can you please explain: ready to land

Added the test commit
You can review the test: https://phabricator.services.mozilla.com/D233224
Let me know if there's any issue.

I have updated the patch.
Right now working on the test.

Thank you for the suggestion! I believe it’s in good shape now. Please let me know if there’s anything else that needs improvement.

Updated the patch.

Updated the patch.

I have done the changes and tested them locally.
For the test file, I have created another commit https://phabricator.services.mozilla.com/D232510