Ryuichi Yamamoto

Possible bug: lpc2lsp

There was a bug in my patch. Fixed (one-line change): --- a/bin/mfcc/_mfcc.c +++ b/bin/mfcc/_mfcc.c @@ -209,22 +209,25 @@ void mfcc(double *in, double *mc, const double sampleFreq, const double alpha, double energy = 0.0, c0 = 0.0; int k; + int memory_size = wlng + wlng + flng + flng + n * 2 + 1 + m * 2; if (x == NULL) { - x = dgetmem(wlng + wlng + flng + flng + n + 1 + m + 1); + x = dgetmem(memory_size); px = x + wlng; wx = px + wlng; sp = wx + flng; fb = sp + flng; - dc = fb + n + 1; + dc = fb...

mfcc: heap-buffer-overflow bug

Hi, this doesn't seem to be fixed entirely. I've quickly looked into the SPTK-3.10 and there was still this kind of bug, at least in _amcep.c, _acep.c and _fftcep.c. Please consider the following pathces: _amcep.c --- bin/amcep/_amcep.c 2016-12-25 14:01:31.000000000 +0900 +++ bin/amcep/_amcep_patch.c 2017-04-22 20:51:46.000000000 +0900 @@ -83,20 +83,21 @@ static int size; double mu, tx; + int expected_size = 3 * (m + 1) + 3 * (pd + 1) + pd * (m + 2); if (bb == NULL) { - bb = dgetmem(3 * (m + 1) +...

Zero division happens in _mgclsp2sp when gamma = 0

I would like to note that the problem might not happen in command line uses, since...

Memory corruption bug in _fftcep

I understand it requires quite a few efforts to fix. I hope you or someone else could...