Skip to content

get_current_rule is incorrectly a noop #79

@SamuelMarks

Description

@SamuelMarks

Expected Behavior

It should be an op, or at least a raise NotImplementedError

Actual Behavior

#75 by @liudangyi created this noop 5-days ago in 354ceb9:

def get_current_rule(op_name: str) -> QuantizationRule | None:
  """Returns the current quantization rule if intercepted, or None otherwise."""
  del op_name
  return None

https://github.com/google/qwix/blob/8f1a822/qwix/_src/qconfig.py#L92-L95

FWIW: process_model_output seems to be a similar function that is a noop stub.

Steps to Reproduce the Problem

Specifications

  • Version: still true at latest main (354ceb9)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions