Replies: 1 comment
-
|
I've had the same question. It probably just grew slowly, and the interested people were fine with it. Splitting it sounds good to me. I don't remember if you have to have a Go file to go with every .cc file, or if it just grabs all of them, but I guess we'll find out. :) |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
When extending functionality, I need to modify
v8go.handv8go.cpp.I wonder why it's one big file, rather than split up, e.g., an
isolate.cpp/isolate.hfor code that is used fromisolate.go, etc.For console interception, I need to have an
InspectorandInspectorClient. I started placing the C++ code in it's own set of files, and that didn't seem to give any problems.I think the code would be much easier to navigate. Particularly because I can easily create editor commands for navigating between same-named
.go,.cc, and.hfiles.But I have no knowledge of CGo except from what I learned working with this code. I don't know if there's a compelling reason for having it in one big file.
Opinions on splitting the v8go C++ and header file into multiple smaller files?
If positive, I think I'd start by making a PR where
IsolateandContextare extracted. Those two are what I depend on for the inspector functionality.Beta Was this translation helpful? Give feedback.
All reactions